Re: [PATCH net 6/7] selftests/xsk: fix too-many-frags multi-buffer Tx test

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The comment describing the invalid packet construction contradicts the new code logic.
--

commit 55a7ead387fcdab87dd100f7febd5012bd365ab8
Author: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

selftests/xsk: fix too-many-frags multi-buffer Tx test

This patch updates the too-many-frags test to keep the oversized packet's
Tx descriptors valid for accounting purposes while ignoring the packet on
the receive side. It also appends a synchronization packet to verify
proper queue draining.

> diff --git a/tools/testing/selftests/bpf/prog_tests/test_xsk.c b/tools/testing/selftests/bpf/prog_tests/test_xsk.c
> --- a/tools/testing/selftests/bpf/prog_tests/test_xsk.c
> +++ b/tools/testing/selftests/bpf/prog_tests/test_xsk.c
[ ... ]
> @@ -2279,21 +2279,29 @@ int testapp_too_many_frags(struct test_spec *test)
>  	/* An invalid packet with the max amount of frags but signals packet
>  	 * continues on the last frag
>  	 */

[Severity: Low]
Does this comment need to be updated to reflect the new code logic?

The comment explicitly states the packet has the max amount of frags and
signals continuation on the last fragment. However, the modified loop now
appends an extra fragment (resulting in max_frags + 1 total fragments)
and explicitly clears the XDP_PKT_CONTD flag on that final fragment.

> -	for (i = max_frags + 1; i < 2 * max_frags + 1; i++) {
> +	for (i = max_frags + 1; i < 2 * max_frags + 2; i++) {
>  		pkts[i].len = MIN_PKT_SIZE;
>  		pkts[i].options = XDP_PKT_CONTD;
> -		pkts[i].valid = false;
> +		pkts[i].valid = true;
>  	}
> +	pkts[2 * max_frags + 1].options = 0;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260623133240.1048434-1-maciej.fijalkowski@intel.com?part=6