Re: [PATCH v7 3/9] bootconfig: render embedded bootconfig as a kernel cmdline at build time

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The host-built tools/bootconfig binary shares the same output directory as the target-built tool, causing an 'Exec format error' when intermixing builds.
--

commit c67f0035f4bd8f4051e26e40c1dccfbeef9c755f
Author: Breno Leitao <leitao@debian.org>

bootconfig: render embedded bootconfig as a kernel cmdline at build time

This commit adds a build-time pipeline to render the embedded bootconfig
kernel subtree into a flat command line string. It wires up the userspace
bootconfig tool to run during the prepare phase on the host to generate
this string.

> diff --git a/Makefile b/Makefile
> index 12fd3d2d47b58..2bb1b44256b5f 100644
> --- a/Makefile
> +++ b/Makefile

[ ... ]

> @@ -1552,6 +1552,22 @@ prepare: tools/bpf/resolve_btfids
>  endif
>  endif
>  
> +# tools/bootconfig renders the embedded bootconfig into a cmdline at build time.
> +ifdef CONFIG_CMDLINE_FROM_BOOTCONFIG
> +prepare: tools/bootconfig
> +endif
> +
> +# tools/bootconfig is run on the build host during prepare, so force a host
> +# binary here; its own Makefile keeps $(CC) for standalone and cross builds.
> +# CROSS_COMPILE= is cleared so tools/scripts/Makefile.include does not inject
> +# the target's --target=/--sysroot= flags into the host clang invocation under
> +# LLVM=1 cross builds (which would produce a target binary that fails to exec).
> +tools/bootconfig: export CC := $(HOSTCC)
> +tools/bootconfig: FORCE
> +	$(Q)mkdir -p $(objtree)/tools
> +	$(Q)$(MAKE) O=$(abspath $(objtree)) subdir=tools -C $(srctree)/tools/ \
> +		bootconfig CROSS_COMPILE=

[Severity: Low]
Will this cause a build failure if the tool is cross-compiled for the target
before the kernel is built?

Since the tool shares the same output directory for both target and host builds,
and its Makefile does not use dependency tracking files to detect compiler
changes, is it possible make will consider a previously cross-compiled binary
to be up to date and skip rebuilding it with the host compiler?

> diff --git a/lib/Makefile b/lib/Makefile
> index 7f75cc6edf94a..4ccdce2fd5e5b 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile

[ ... ]

> @@ -273,6 +273,22 @@ filechk_defbconf = cat $(or $(real-prereqs), /dev/null)
>  $(obj)/default.bconf: $(CONFIG_BOOT_CONFIG_EMBED_FILE) FORCE
>  	$(call filechk,defbconf)
>  
> +obj-$(CONFIG_CMDLINE_FROM_BOOTCONFIG) += embedded-cmdline.o
> +$(obj)/embedded-cmdline.o: $(obj)/embedded_cmdline.bin
> +
> +# Render the bootconfig "kernel" subtree to a flat cmdline string using
> +# the userspace tools/bootconfig parser (-C mode). The runtime prepend
> +# helper enforces COMMAND_LINE_SIZE at boot, so no build-time size
> +# check is performed here (COMMAND_LINE_SIZE is an arch header
> +# constant, not a Kconfig value).
> +quiet_cmd_render_cmdline = BCONF2C $@
> +      cmd_render_cmdline = \
> +	$(objtree)/tools/bootconfig/bootconfig -C $< > $@

[Severity: Low]
If the prepare phase skips rebuilding the tool because a cross-compiled
version already exists, will this execution fail with an Exec format error
when it attempts to run a target architecture binary on the build host?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260626-bootconfig_using_tools-v7-0-24ab72139c29@debian.org?part=3