From: sashiko-bot@kernel.org
To: "Sechang Lim" <rhkrqnwk98@gmail.com>
Cc: bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v3 2/2] selftests/bpf: drop tc/xdp/flow_dissector sockmap mutation tests
Date: Mon, 29 Jun 2026 17:48:25 +0000 [thread overview]
Message-ID: <20260629174825.95C2D1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260629172704.1302218-3-rhkrqnwk98@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit deletes the selftest file test_sockmap_update.c but leaves broken references to it in the sockmap documentation.
--
commit ccad6ec599cc55c0fbdeda989132b9073df009d1
Author: Sechang Lim <rhkrqnwk98@gmail.com>
selftests/bpf: drop tc/xdp/flow_dissector sockmap mutation tests
tc, xdp and flow_dissector programs can no longer update or delete a
sockmap. Adjust the tests and remove the now-unused test_sockmap_update.c
and freplace_cls_redirect.c files.
> diff --git a/tools/testing/selftests/bpf/progs/test_sockmap_update.c b/tools/testing/selftests/bpf/progs/test_sockmap_update.c
> deleted file mode 100644
> index 6d64ea536e3d8..0000000000000
> --- a/tools/testing/selftests/bpf/progs/test_sockmap_update.c
> +++ /dev/null
[Severity: Low]
Does this commit also need to update Documentation/bpf/map_sockmap.rst?
Since test_sockmap_update.c is being removed here, the literal references
and hyperlinks to it in Documentation/bpf/map_sockmap.rst (around lines
352 and 498) are left as broken links.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260629172704.1302218-1-rhkrqnwk98@gmail.com?part=2
prev parent reply other threads:[~2026-06-29 17:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 17:26 [PATCH bpf-next v3 0/2] bpf, sockmap: disallow sockmap mutation from tc, xdp and flow_dissector Sechang Lim
2026-06-29 17:27 ` [PATCH bpf-next v3 1/2] bpf, sockmap: disallow update and delete " Sechang Lim
2026-06-29 17:42 ` sashiko-bot
2026-06-29 18:06 ` bot+bpf-ci
2026-06-29 18:24 ` Alexei Starovoitov
2026-06-30 5:47 ` John Fastabend
2026-06-30 7:14 ` Sechang Lim
2026-06-29 17:27 ` [PATCH bpf-next v3 2/2] selftests/bpf: drop tc/xdp/flow_dissector sockmap mutation tests Sechang Lim
2026-06-29 17:48 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260629174825.95C2D1F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=rhkrqnwk98@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox