Re: [PATCH bpf-next v4 2/2] selftests/bpf: drop tc/xdp/flow_dissector/socket_filter sockmap mutation tests

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Stale references and dangling links to the deleted file `test_sockmap_update.c` in BPF documentation.
--

commit ce41dd2fcf64eeb09dfffd2596dead28c4261583
Author: Sechang Lim <rhkrqnwk98@gmail.com>

selftests/bpf: drop tc/xdp/flow_dissector/socket_filter sockmap mutation tests

The commit removes test cases where tc, xdp, socket_filter, and
flow_dissector programs attempt to update or delete a sockmap, as these
operations are no longer allowed. It also removes the now unused
test_sockmap_update.c and freplace_cls_redirect.c files.

> diff --git a/tools/testing/selftests/bpf/progs/test_sockmap_update.c b/tools/testing/selftests/bpf/progs/test_sockmap_update.c
> deleted file mode 100644
> index 6d64ea536e3d8..0000000000000
> --- a/tools/testing/selftests/bpf/progs/test_sockmap_update.c
> +++ /dev/null
> @@ -1,48 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0

[Severity: Low]
Should we also update the BPF documentation to remove references to this
deleted file?

Documentation/bpf/map_sockmap.rst appears to reference it as an
example of kernel BPF sockmap usage, and includes a hyperlink target
that will now be broken:

.. _`tools/testing/selftests/bpf/progs/test_sockmap_update.c`: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/bpf/progs/test_sockmap_update.c

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260630145410.3648099-1-rhkrqnwk98@gmail.com?part=2