Re: [RFC PATCH bpf-next v1 7/7] selftests/bpf: cover bpf_xdp_metadata_rx_csum in xdp_metadata

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added multi-line comment in `verify_xsk_metadata` violates the BPF subsystem comment style guidelines.
--

commit f8507da4f2875a0c3ae86814a72a21202665e4a5
Author: Vladimir Vdovin <deliran@verdict.gg>

selftests/bpf: cover bpf_xdp_metadata_rx_csum in xdp_metadata

This commit updates the xdp_metadata test to call bpf_xdp_metadata_rx_csum()
and export its status to userspace. It then asserts the expected checksum
status depending on whether the frame was injected via AF_XDP or sent
through the stack.

> diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_metadata.c b/tools/testing/selftests/bpf/prog_tests/xdp_metadata.c
> index 5c31054ad4a4c..77f55696eb786 100644
> --- a/tools/testing/selftests/bpf/prog_tests/xdp_metadata.c
> +++ b/tools/testing/selftests/bpf/prog_tests/xdp_metadata.c
> @@ -310,6 +310,16 @@ static int verify_xsk_metadata(struct xsk *xsk, bool sent_from_af_xdp)
>  	if (!ASSERT_NEQ(meta->rx_hash, 0, "rx_hash"))
>  		return -1;
>  
> +	/* veth surfaces the checksum verdict from skb->ip_summed.  A packet
> +	 * injected via AF_XDP carries no checksum context and is CHECKSUM_NONE,
> +	 * while one sent through the stack is CHECKSUM_PARTIAL and reads back as
> +	 * verified.
> +	 */

[Severity: Low]
This isn't a bug, but does this comment format match the BPF subsystem
multi-line comment style guidelines? 

The BPF subsystem typically requires the opening /* to be on its own line,
rather than sharing a line with the first row of text.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260630191510.81402-1-deliran@verdict.gg?part=7