From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97C0B3B3BF4 for ; Sat, 4 Jul 2026 12:29:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783168198; cv=none; b=Wh8vtsRESBymW4r5L173W6F9GyWhXxSbZ/wY8p6RJXcdtqauTyVt7+2RQvKzk1Pps3vnKWZH6iBWPzeMUgVYk3jBvbK0xzJA2s8gW1seLMxeEBnlj1KwQvQ8KPlkYegswI++wIhyxv+pLJlBweB9wR5jOLH56C4dKlTFDRFSXoA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783168198; c=relaxed/simple; bh=cP16KMgkXs8B4/PcMRS86NXP4aXKyjKM/OK1Wgw7CsA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gMz/gGDtr0AcZmu3x9xEa1SMMweeHy0GLWd83GGZdLzCv/oomsrfIZ+HEktisWwy1XoiQ4kFtzsnEHMwxNxE194WgzqtE/yX03Jxs57uXAawQc7PPPEzEC6Ixc99CTRm0BIC3+IFNLKETkdsahfACR4Bl2qa+72sIaFGG1ni5WM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gGV3DI7J; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gGV3DI7J" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-37d70036426so953925a91.3 for ; Sat, 04 Jul 2026 05:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783168192; x=1783772992; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0/l4Gk6A9ZTMBN6K1Vyblne4TPYpWKLwwp9lrwI82n8=; b=gGV3DI7JVJDuDYwS0d77zVjz377tsge/PytYgzedzFhDKlrj/lBaZFCMWaCC3JCWiP tNnDwMZ5e+zxIVdKJVeks7f/mkGreRUDn86qaBBQuXvZ91W3CKvY3sPOiwTajYQVlTK1 MqKDgAuRqx2jFX8L+uJrd7jfyTsRPg3MYMliP2G+XvGq15125bOJ2FqCbI+Hj9ILSKuO YjROAr8k7Fk77ch0elwo01SHbedHLO1Rbo+mavHyz0dEJzqt5N1lAuTSnRhMJUGgX0jS pqM2tTxIfojZtsZXjsxhD0Ks2FfWT3DES5fylGSZqOJIBa7lFpBB6x5VdwW1P57VCv+t u52g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783168192; x=1783772992; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0/l4Gk6A9ZTMBN6K1Vyblne4TPYpWKLwwp9lrwI82n8=; b=hIrHzCs9smQTlvcYF2Jg86sJTEheCTmm5dcDUUjUmBT84VWDJ1tkcGSVQMQmlEVTw1 kUghitkdXvcOF0Y2/ooFs8j+5WkHJ/DDs+V2MsTXBao/qnq6J3DQtc1hqBH1nsuOH6Cp WIt7amOnhLFKqPf8eFHfX8PwOxG1J7C++iRC9BKVQ+8vCugjFMYz6DSEVoUuCUHHCvGs O3ejwS79IIrS9MCZ5T294JjdZY4u1+YBsJJ7G857RmZk66VzTTPsrFT+xs9cgnHiC5P0 ZO6EsPtutvfA91PX5kMjJcoJhFMHudWpwMD6s4sjf1asvHfZmZUVqvg6VtF+nLTXs/UL 1LDg== X-Forwarded-Encrypted: i=1; AHgh+Rou5lL3E3v0e0WiO3jMem303b5RX+XlWjkRj/LWQRc/kG0K++K2obTA8eBP+CuaMAQ6XxA=@vger.kernel.org X-Gm-Message-State: AOJu0YwOKemLS9GjTWV2uKy32Fpp/TlBTEd/KP/Rfb/Fm2sXe64SJVOK YigwUsyGuEvvg5kK/clE2WfebVROxM4MAzEvxnHI8Is0xE5Yx8ng3rnD X-Gm-Gg: AfdE7cmUrgbPaXZgiwskKq5EY0qUW0hjcjffWqVR4uRZhABIT6bhZS+jmqnT/amLLpm k7qGGaiYNF5Ber5ukhhvaWYhdo/d2tm2wz2fQ4AqaF4VdmTeecEIMeAKcsFPmh96sfIblNXcciy 4rsagXWlmy74H1MLhrhE8TdTL6N4kYrGubgd4RZXWpUzKFCjBieyj0/BqiU7/2M0EubqjONuKc6 ihTdrS9R6fGMFBLN7Z5GQfXawAN1G3IfwylxVlKAoW2ouxxUCeXvCLyFmlhUAnf7hX/ABTpPb9e BRPAJXnPulleyZ3bZ+aXnE/YNpSb5yAjXTSOgtkFy8/qlYnlRbJHXis1wtjBVKXBYHPlREiT7oD XttPbJRU4tB4vQ337dtX4rMFepz+zhPDQj9QekLe5XuiGS5TkjInRYOSHXaF0OkTv3zxaNCQPew 8UoyAV1XWJ53ywBvEOF9nWHbowwe6Mm0ttaYhb02hE7QBrsYqhaUpRuBebKw== X-Received: by 2002:a17:90b:3a50:b0:381:149:cf91 with SMTP id 98e67ed59e1d1-3829f2f84b2mr3070002a91.26.1783168191679; Sat, 04 Jul 2026 05:29:51 -0700 (PDT) Received: from fedora.mrout-thinkpadp16vgen1.punetw6.csb ([103.133.229.222]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f3d92c44bsm10265522eec.19.2026.07.04.05.29.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 05:29:51 -0700 (PDT) From: Malaya Kumar Rout To: andrii@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev Cc: Malaya Kumar Rout , Alexei Starovoitov , Eduard Zingerman , Kumar Kartikeya Dwivedi , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Shuah Khan , John Fastabend , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] selftests/bpf: Fix memory leak in msg_alloc_iov error path Date: Sat, 4 Jul 2026 17:59:35 +0530 Message-ID: <20260704122936.102394-1-malayarout91@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <7f3e0f9992a32264f6c7cf00f2ef3ce87a0a6fbd6703084aff3de68cda77dc9c@mail.kernel.org> References: <7f3e0f9992a32264f6c7cf00f2ef3ce87a0a6fbd6703084aff3de68cda77dc9c@mail.kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In msg_alloc_iov(), when calloc() fails for an individual iov_base allocation, the error path frees all previously allocated iov_base entries but fails to free the iov array itself that was allocated with calloc() at the beginning of the function. This results in a memory leak of the iov array. Add free(iov) in the unwind_iov error path to ensure proper cleanup of all allocated memory. Fixes: 753fb2ee0934 ("bpf: sockmap, add msg_peek tests to test_sockmap") Signed-off-by: Malaya Kumar Rout --- tools/testing/selftests/bpf/test_sockmap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c index ac814eb63edb..3e6be455d158 100644 --- a/tools/testing/selftests/bpf/test_sockmap.c +++ b/tools/testing/selftests/bpf/test_sockmap.c @@ -436,6 +436,7 @@ static int msg_alloc_iov(struct msghdr *msg, unwind_iov: for (i--; i >= 0 ; i--) free(msg->msg_iov[i].iov_base); + free(iov); return -ENOMEM; } -- 2.54.0