Re: [PATCH bpf 2/2] selftests/bpf: Add XDP dispatcher FineIBT regression test

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The test modifies global host networking state by attaching an XDP program to the loopback interface, but is not serialized or isolated in a network namespace, causing race conditions in concurrent CI test runs.
--

--- Patch [2]: [PATCH bpf 2/2] selftests/bpf: Add XDP dispatcher FineIBT regression test ---
commit 5a870a8bf864ee8b6c4ae366f0fe61e22b615aee
Author: David Windsor <dwindsor@gmail.com>
selftests/bpf: Add XDP dispatcher FineIBT regression test

This commit adds a regression test for the x86 BPF dispatcher's indirect-jump
fallback under FineIBT.

> diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_dispatcher_fineibt.c b/tools/testing/selftests/bpf/prog_tests/xdp_dispatcher_fineibt.c
> new file mode 100644
> index 0000000000000..2d3fc4034eb90
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/prog_tests/xdp_dispatcher_fineibt.c

[ ... ]

> +#define IFINDEX_LO		1
> +
> +void test_xdp_dispatcher_fineibt(void)
> +{

[ ... ]

> +	attached_fd = bpf_program__fd(skel->progs.xdp_dispatcher_attached);
> +	unattached_fd = bpf_program__fd(skel->progs.xdp_dispatcher_unattached);
> +
> +	err = bpf_xdp_attach(IFINDEX_LO, attached_fd, XDP_FLAGS_SKB_MODE, NULL);

[Severity: Medium]
Since this test modifies the global loopback interface by attaching an XDP
program, and lacks the serial_test_ prefix or network namespace isolation,
could this cause flaky failures in other concurrently running tests?

By BPF selftests convention, shouldn't tests that modify global networking
state either be isolated in a dedicated network namespace or use the
serial_test_ prefix to guarantee sequential execution?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/c5a6bff16c0885d3ec756a1cdfb623636d0bdb4a.1783479101.git.dwindsor@gmail.com?part=2