From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E5303E9C0E for ; Wed, 8 Jul 2026 06:53:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783493593; cv=none; b=gwVyR2Na306bL+IpSxJn8Kmta71FiaiLg3JysFpBNEmyml2bxZ8s+HIfYiCyifvWEo1KkHLSJnDYCW/pxR4j4wA7mjd9PgOIhx/RA6qoHGGs+bqNWyVBOqg8Ntsf8VzsIeeKhpFQlbvYiG0tzmjDMbvBTm1AhCLxcE6eUEs5Q60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783493593; c=relaxed/simple; bh=YTZC1tr0nF6mz4Z+4cqem9+KX4IQ0CP2cybl++qADNQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QsAxoYFgmmSAZQnMujrRj3uenk7L8j6O6b07sUmdzfZpbOE9kDF6GJ0267cfbCpST5Dws4NerSA0UfXgKV8GqjUVHWGjQdHXxuAY4TCAVA30NQjnjzgbXfwMbVYgBb85eq2gJ2b4kMwfenMm8eFLoRoybMdSpfciPMXTUR2x2vY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Np8YW2Hn; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Np8YW2Hn" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2c6b67d5fa1so4117595ad.2 for ; Tue, 07 Jul 2026 23:53:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783493582; x=1784098382; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YTZC1tr0nF6mz4Z+4cqem9+KX4IQ0CP2cybl++qADNQ=; b=Np8YW2HnkALw/xRrFfngFUj8otJKmcYuTIIN/db4lY5ISBdJricV67NiABm5y2FS+f MPNQ+HoPRztd7y+Ga/tm3kJIrHR4wGJ4znD153WbviAguRHlgblZ00A5KCNF6gtR2ZSI kgorU6o2TvE6HG+SYBXCvA8x4AxyqEt5hU6OimI3DBoYFJJrybgCWpScUIrT+l72fOgK le0WYDAlvjXSWGszj4tfOc6rlc69HhIKYPoADVM3i5hfxZQX4/DrciTD4S+lUGy6g+ZS J514ayb6O2x99c5Z6x7mQ0UzYvBm4zrdAfVckr4i+3+0XR6FHaBixcyULUQ5skgqJFRO 1tBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783493582; x=1784098382; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=YTZC1tr0nF6mz4Z+4cqem9+KX4IQ0CP2cybl++qADNQ=; b=IQaJ1hO7GbNQ8YZ2F/LQd4vcBLJRp5YAa2tKDQh5Yh+QCKk+A9eh4FfFvX5c8fhPmY K3Wm8l2uB9HmfmEultWfE8IO9V+qX/v86GWHefQRZT3bnA1npbrzlE9POyVbmoZXTAfd EDEwDwKV44ND6sgcBEGtEX1FqO6tbTCc5j8mcRlTzMGz0Zbbalbjq1CXnxYGkx2LJCym rqpz/x9FyHuu5AEHqqXOuFP49sYHunynKxdIHiw1yEbEWuY3XH+KLdHLY3/v5xFBB/oE 5ynUTZ0k6VxgvhsRPjvGDTDlJunD6I5jI9e7TRV6eIVBAwmHV6TMikAGn4xvWb4ve1AC Iovg== X-Forwarded-Encrypted: i=1; AHgh+Rrv7lbcDpJ8I3PylCxOiwm+HOcpeMYnBJvG/noo/IqKIooQV+dHBY/Z+LJFnGDtBVbbZlI=@vger.kernel.org X-Gm-Message-State: AOJu0YzALo3DoVnqX15clBcnnPqavbZLc0fCF1prcnFyJUNe+3YTnyWs 0Q0rMpRtRd82c7Vcgr10jgWG74q06Nt8RS6gVBNN3c3c4WJNLE9aoHiG X-Gm-Gg: AfdE7clcxQqTh39MMk5fFDESnYK8LIQAyL0YHOR3KTdoLGksOXRpOlax3519J8xYdNL 2VKg4jEt13wMQEfr7xNbkLERbpYu/RENLN1pfEvBS6gDP87U97lldgbAleKsODCGwAv/6qh30an ka7U0bxarC8+Un5uWRh3EIm1EaqRfw2ceOBhZowW+yA5RevTq086qQU8mfdikGyEl9wvQLlRzLe P321+ZTCLGu63mDJhBd2Fm+gebBYXx5P2LGkSy9lSnMGNCfSZVeiWOVrG7lMdohaQzfWEBIMNqj Vx1WA6rFxA/11JFy9mTjVYKpgWvUZg7de5KhFj++6etXPuvVx10wekICMcNAY/VKGABRBbzw5Ca GRRvtt10WvDz554xdBfltWNzTrfsQseB0GKAZtZL3lywLWRiWdJrsLuLIPgC+P8mFZJPbJnuyEH ZFPAb2WeV2tclabm7WBYLYNXs2xqJnRgOGPvfcxFiCg/BkyKxk2NRiD9T9m7dB X-Received: by 2002:a05:6a20:258b:b0:3b4:7eb0:47a1 with SMTP id adf61e73a8af0-3c0bceb6c9fmr1504879637.19.1783493582085; Tue, 07 Jul 2026 23:53:02 -0700 (PDT) Received: from r912.tailbb6e1e.ts.net ([182.70.116.80]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b6596681fsm18477898c88.8.2026.07.07.23.52.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 23:53:01 -0700 (PDT) From: Avinash Duduskar To: emil@etsalapatis.com, andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net Cc: a.s.protopopov@gmail.com, ameryhung@gmail.com, bpf@vger.kernel.org, davem@davemloft.net, dsahern@kernel.org, eddyz87@gmail.com, edumazet@google.com, eyal.birger@gmail.com, hawk@kernel.org, horms@kernel.org, john.fastabend@gmail.com, jolsa@kernel.org, kpsingh@kernel.org, kuba@kernel.org, leon.hwang@linux.dev, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, martin.lau@linux.dev, memxor@gmail.com, netdev@vger.kernel.org, pabeni@redhat.com, rongtao@cestc.cn, sdf@fomichev.me, shuah@kernel.org, song@kernel.org, toke@redhat.com, yatsenko@meta.com, yonghong.song@linux.dev Subject: Re: [PATCH bpf-next v6 3/3] selftests/bpf: Add bpf_fib_lookup() VLAN flag tests Date: Wed, 8 Jul 2026 12:22:50 +0530 Message-ID: <20260708065250.707983-1-avinash.duduskar@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: References: <20260704092159.1256823-1-avinash.duduskar@gmail.com> <20260704092159.1256823-4-avinash.duduskar@gmail.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > Here we add a bunch of shorthands for the topology we're setting up, > but not for all interfaces/IPs. E.g., [...] > The IPs are hardcoded here (and in the rest of the code below). AFAICT the > logic is that the defines are to make it more obvious as to what the test > is about. Is there a logic of this kind behind the naming convention? Yes, the rule is inherited from the file: a value gets a define when setup_netns() and the assertion table both use it, so the two sites cannot drift and a table arm names what it targets (.daddr = IPV4_VLAN_GW reads as intent). The new defines follow that. The hardcoded addresses are in the netns and live-frames subtests, which build their own single-function topologies the table never references, so there is no second site to keep in sync. The bare "veth1"/"veth2" strings predate this series; I left them alone rather than churn lines the series does not otherwise touch. The netns subtest does repeat its 10.66.0.x addresses a few times, though, so I will give those a local define in v7 to keep the new code consistent with itself. Thanks for the reviews! Avi