From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from www62.your-server.de (www62.your-server.de [213.133.104.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03A353AB5B8; Wed, 8 Jul 2026 07:53:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.133.104.62 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783497245; cv=none; b=CVtryY6dKqLyIjyjj611v3R5PBB50mrcQXmum2rprYumBVIUzlCRlnGEEk8buBUd+LA1Ir4YdKhQ0OILbkVtJKduFU7N8VqR6vYDai3eMHu8yqSOM4nVTBYSBdCaghpO1LcPqe7cHvZqh4/Vf3AHgjEAVQzlBxOvs1LjaPmyKiU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783497245; c=relaxed/simple; bh=x8XtNeRZvgX8/szMrzvnvHxfMPOTfjSDwOCtgahJIjs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e/c+kS48LVEntjkQ0QnjeEz5+um7bOyiCTNQxA6hyj5PSUNT4kIs1tqro3Um5czPFlxRUSztyFTsW+EYo4xe2XNktJv3Y0uZFmeNlUPYuDKJhD3KS88nywjUue5AkzCQnVmLAmeUXatWgIhfw1MZgm5ueJz5nvnnlvqc4IDUxsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iogearbox.net; spf=pass smtp.mailfrom=iogearbox.net; dkim=pass (2048-bit key) header.d=iogearbox.net header.i=@iogearbox.net header.b=Jbdqm9T8; arc=none smtp.client-ip=213.133.104.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iogearbox.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iogearbox.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iogearbox.net header.i=@iogearbox.net header.b="Jbdqm9T8" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=iogearbox.net; s=default2302; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=K91/uupA3BSM2SUVEXpcffcMKiZwTtNrMEHJT3/jLt0=; b=Jbdqm9T8DDDlEd358LvkpzZ5e4 I37d7HHS4nACas7vbJW7EgSPwde2Nm7/lQxD8/kvONR2MtytF+meG6drYLMDo5LsHwfO0cRnolxs5 bpooD+tam/C+9OtR/ddmZMXLBFDTNN0zT0rH0ilL9Rj5AejIKOgjqpxEA2M7qGiUZf29gdT1gMQoh nktLCJjKco10Hh9LP6NIU992DkIiHo1qS/8DW+72oHBKyDHlOpkKMkYmCK5I+M6hmlWktR6IGkw+f bs1Myy8NGO3vPWULqUlWV81QBz3lAaQmJSJETKNTaSZdOLwe3zty8cgWbJg/JrrJoI09zzTSREW7d VWVu4xIw==; Received: from localhost ([127.0.0.1]) by www62.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1whN6K-000Ge1-1p; Wed, 08 Jul 2026 09:53:48 +0200 From: Daniel Borkmann To: ast@kernel.org Cc: kpsingh@kernel.org, James.Bottomley@hansenpartnership.com, paul@paul-moore.com, bboscaccy@linux.microsoft.com, memxor@gmail.com, torvalds@linux-foundation.org, a.s.protopopov@gmail.com, bpf@vger.kernel.org, linux-security-module@vger.kernel.org Subject: [PATCH bpf-next v6 4/8] bpftool: Check EVP_Digest when computing excl_prog_hash Date: Wed, 8 Jul 2026 09:53:39 +0200 Message-ID: <20260708075343.358712-5-daniel@iogearbox.net> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260708075343.358712-1-daniel@iogearbox.net> References: <20260708075343.358712-1-daniel@iogearbox.net> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Virus-Scanned: Clear (ClamAV 1.4.3/28054/Wed Jul 8 08:24:53 2026) bpftool_prog_sign() ignores the return value of EVP_Digest(). If the digest computation fails (context allocation failure, or a digest fetch failure under OpenSSL), EVP_Digest() returns 0 and leaves the output buffer untouched, but the function still reports success. Fixes: 40863f4d6ef2 ("bpftool: Add support for signing BPF programs") Signed-off-by: Daniel Borkmann --- tools/bpf/bpftool/sign.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/bpf/bpftool/sign.c b/tools/bpf/bpftool/sign.c index f9b742f4bb10..1257dba8ef2f 100644 --- a/tools/bpf/bpftool/sign.c +++ b/tools/bpf/bpftool/sign.c @@ -175,8 +175,11 @@ int bpftool_prog_sign(struct bpf_load_and_run_opts *opts) goto cleanup; } - EVP_Digest(opts->insns, opts->insns_sz, opts->excl_prog_hash, - &opts->excl_prog_hash_sz, EVP_sha256(), NULL); + if (EVP_Digest(opts->insns, opts->insns_sz, opts->excl_prog_hash, + &opts->excl_prog_hash_sz, EVP_sha256(), NULL) != 1) { + err = -EIO; + goto cleanup; + } bd_out = BIO_new(BIO_s_mem()); if (!bd_out) { -- 2.43.0