From: Eric Biggers <ebiggers@kernel.org>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH 29/33] bpf: crypto: Use AES-CBC and AES-ECB libraries
Date: Thu, 9 Jul 2026 11:47:13 -0400 [thread overview]
Message-ID: <20260709154713.GB6853@quark> (raw)
In-Reply-To: <5f9c3aab-5339-463c-a86d-edac297e1e95@linux.dev>
On Wed, Jul 08, 2026 at 12:47:43PM +0100, Vadim Fedorenko wrote:
> On 08/07/2026 00:16, Eric Biggers wrote:
> > On Tue, Jul 07, 2026 at 11:50:33PM +0100, Vadim Fedorenko wrote:
> > > > Does this mean the AES-ECB support is unnecessary and can be dropped?
> > >
> > > Let's keep it if it doesn't hurt.
> >
> > It kind of does. It is "bad" crypto that would have to continue to be
> > maintained, and someone might start using it accidentally.
>
> AES-ECB was introduced as a cipher to use in QUIC-LB draft,
> draft-ietf-quic-load-balancers-21
>
> I know it is expired draft, but it may be worth keeping this cipher
> as QUIC WG github is still active
Sigh. We shouldn't implement Internet-Drafts that have clear issues
with how they use cryptography. They're likely to change when they
undergo cryptography review. We went through this same thing with
TCP-AO, where I ended up joining the tcpm working group and getting the
draft fixed. Do I need to do the same with this one too?
- Eric
next prev parent reply other threads:[~2026-07-09 15:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260707053503.209874-1-ebiggers@kernel.org>
[not found] ` <20260707053503.209874-30-ebiggers@kernel.org>
2026-07-07 15:01 ` [PATCH 29/33] bpf: crypto: Use AES-CBC and AES-ECB libraries Vadim Fedorenko
2026-07-07 18:20 ` Eric Biggers
2026-07-07 22:50 ` Vadim Fedorenko
2026-07-07 23:16 ` Eric Biggers
2026-07-08 11:47 ` Vadim Fedorenko
2026-07-09 15:47 ` Eric Biggers [this message]
2026-07-09 16:46 ` Vadim Fedorenko
[not found] ` <20260707053503.209874-31-ebiggers@kernel.org>
2026-07-07 15:02 ` [PATCH 30/33] bpf: crypto: Add AES-GCM support Vadim Fedorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709154713.GB6853@quark \
--to=ebiggers@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox