Re: [PATCH 2/2] selftests/bpf: enable timed may_goto tests for riscv64

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing test enablement for riscv64 timed may_goto expansion and bpf_fastcall interaction.
--

--- Patch [2]: [PATCH 2/2] selftests/bpf: enable timed may_goto tests for riscv64 ---
commit c54da59713ded8c765c2c6ab6331451df77083c9
Author: Feng Jiang <jiangfeng@kylinos.cn>

selftests/bpf: enable timed may_goto tests for riscv64

This commit enables the verifier_may_goto_1 and stream_cond_break tests
on riscv64 now that the JIT supports timed may_goto.

> diff --git a/tools/testing/selftests/bpf/progs/stream.c b/tools/testing/selftests/bpf/progs/stream.c
> index 92ba1d72e0ece..8d8e53d37266c 100644
> --- a/tools/testing/selftests/bpf/progs/stream.c
> +++ b/tools/testing/selftests/bpf/progs/stream.c
> @@ -64,6 +64,7 @@ SEC("syscall")
>  __arch_x86_64
>  __arch_arm64
>  __arch_s390x
> +__arch_riscv64
>  __success __retval(0)
>  __stderr("ERROR: Timeout detected for may_goto instruction")

[ ... ]

[Severity: Medium]
Should tools/testing/selftests/bpf/progs/verifier_bpf_fastcall.c also be
updated to include __arch_riscv64 for the may_goto_interaction_arm64 test?

This test verifies the expansion of timed may_goto when interacting with
bpf_fastcall, but currently lacks the riscv64 architecture tag.

riscv64 shares the exact same verifier translation and fastcall behavior for
this path:

tools/testing/selftests/bpf/progs/verifier_bpf_fastcall.c:
    ...
    SEC("raw_tp")
    __arch_arm64
    __log_level(4) __msg("stack depth 24")
    /* may_goto counter at -24 */
    ...
    __success
    __naked void may_goto_interaction_arm64(void)
    ...

Without this tag, the test for this specific timed may_goto interaction is
silently skipped when running BPF selftests on riscv64.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260714-riscv-bpf-timed-may-goto-v1-0-3988601fe6ac@kylinos.cn?part=2