Re: [PATCH] libarena/selftests: use ARRAY_SIZE macro in st_asan_buddy.bpf.c

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit introduces the `ARRAY_SIZE` macro into a BPF program without defining or including it, causing a compilation failure.
--

--- Patch [1]: [PATCH] libarena/selftests: use ARRAY_SIZE macro in st_asan_buddy.bpf.c ---
commit 70521e8b40248839f7100def222aa4fb06724c32
Author: longlong yan <yanlonglong@kylinos.cn>
libarena/selftests: use ARRAY_SIZE macro in st_asan_buddy.bpf.c

This commit replaces manual array size calculations with the ARRAY_SIZE macro 
in the asan_test_buddy_oob and asan_test_buddy_uaf functions to make the code 
more compact.

> diff --git a/tools/testing/selftests/bpf/libarena/selftests/test_asan_buddy.bpf.c b/tools/testing/selftests/bpf/libarena/selftests/test_asan_buddy.bpf.c
> index 3266a28f53d76..9c94a5167a503 100644
> --- a/tools/testing/selftests/bpf/libarena/selftests/test_asan_buddy.bpf.c
> +++ b/tools/testing/selftests/bpf/libarena/selftests/test_asan_buddy.bpf.c
> @@ -163,7 +163,7 @@ __weak int asan_test_buddy_oob(void)
>  		return ret;
>  	}
>  
> -	for (i = zero; i < sizeof(sizes) / sizeof(sizes[0]) && can_loop; i++) {
> +	for (i = zero; i < ARRAY_SIZE(sizes) && can_loop; i++) {

[Severity: Low]
Does this cause a compilation failure when building the BPF selftests?

It appears that ARRAY_SIZE is not defined in this BPF program or its currently
included headers. Would we need to define ARRAY_SIZE locally in this file, or
include a header that provides it specifically for BPF environments?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716071110.560-1-yanlonglong@kylinos.cn?part=1