Re: [PATCH bpf-next v1 2/2] selftests/bpf: Test duplicate unique fields in nested structs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Multi-line comment style violates BPF subsystem guidelines.
--

--- Patch [2]: [PATCH bpf-next v1 2/2] selftests/bpf: Test duplicate unique fields in nested structs ---
commit 9b7a72ba7e7b55aa85d89f130fc6922658c4bcf0
Author: Kumar Kartikeya Dwivedi <memxor@gmail.com>

selftests/bpf: Test duplicate unique fields in nested structs

This commit adds a raw BTF test with a spin lock directly in a struct
and another in a nested struct to ensure duplicates are rejected during
BTF loading.

> diff --git a/tools/testing/selftests/bpf/prog_tests/btf.c b/tools/testing/selftests/bpf/prog_tests/btf.c
> index 66855cbd6b73f..02c4c60c841ee 100644
> --- a/tools/testing/selftests/bpf/prog_tests/btf.c
> +++ b/tools/testing/selftests/bpf/prog_tests/btf.c
[ ... ]
> @@ -4250,6 +4250,32 @@ static struct btf_raw_test raw_tests[] = {
>  	.max_entries = 1,
>  },
>  
> +/* struct inner {
> + *     struct bpf_spin_lock lock;
> + * };

[Severity: Low]
This isn't a bug, but does this multi-line comment format violate the BPF
subsystem style guidelines? The BPF guidelines prefer the opening /* to be on
its own line rather than having text on the same line as the opening.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260719142401.2420111-1-memxor@gmail.com?part=2