From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABF4A264A86 for ; Sun, 19 Jul 2026 15:22:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784474563; cv=none; b=LgwEEYgS82ylSimy1pQqhYUYt7L7VIAbHQb9/uGotQVusMzTQWCgtnZi3jazBp+uaAur+TqT8YT5kGXbrNvlIHpMNsBFxkj9UFgjgcmspaZySHfsfllIBS4yk3EJf4RKXksY+UlfnGNYZU4r/P3rdYWGDFURxN5ytEPRh6Rfs50= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784474563; c=relaxed/simple; bh=I4z8RcddTk/W6eb/VEggN6eIMMI5w0xL7uumLhDLtkg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ab5VdV8tx/ScQKJtjpkhhbm3C8kLvFJU6PFnHUPV76G0VLjcXz34CtezTytnsUZxzK7+meRzFOU6vpxiYs+aHd5IAjsw1RjPOuWaqctEuTabw/aMUeu3sDNhgHYGjYLgx4DtaBfhm+ZvhsfE/uXIkm2RZ4YW11ZO7SA4AM912cw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Dcj03gxl; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dcj03gxl" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2cad68425a7so13693615ad.1 for ; Sun, 19 Jul 2026 08:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784474562; x=1785079362; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=4/kAZZ6CXcXVTT9Vyn6wjy2NgA+oPqodreHoRRBv/nk=; b=Dcj03gxlgbqH1eRH2R5C1Z/nou2byrsBbk0JMWELKczlRE+SVpXumjH37kw/UWwFqp KIYwVT442fJ6MUfZy3sVWp7fECRVAf9r0/0v6V1nnufSoc+5dKrrXJ3ciHpr3TMjHJDO uJJ7yt96+f4aFzryIjMZwsCYQfgtjVPLiVLrgf+xO5klGpEUkGmprUzOEHgYHcr2ZvHU udJtOP3qDVM2gXkYkDbVjjuBnegjntNPMCQkBErMrJvWuehnh+roqaRjqmqhyk5joMBw 0jAz1ib87VTPQSmCZwRPSQm4pnpHZYyNsdZ0B8xcio4tgm4ZpWyHVyi6eO5N4+qiShvZ G5nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784474562; x=1785079362; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4/kAZZ6CXcXVTT9Vyn6wjy2NgA+oPqodreHoRRBv/nk=; b=TqSku68Io9Kzr0Y6IOke+gaPV+aVHsdCPnGVbgol11k7jPftG6rAvNW8Nu2M8NL1A+ n6XK0fuj96uinu4xa9c7c3kPE52kFvBH7BpG+Bbs009mhZZI10ZxR7+76mVJ8GDS1zS9 s/Lkm5QfUsn2xwAnasiLRpE2NDHBJwqlnnEdSWOw17NyluXhzLNSEYVIUgGvp8zCBSJj LjcUalmt+mCgwpGcPvRhSN9KifPwNdUm3MoF0VEHWBmsEQhsI8qYP56NOHGxadF9ooZc pHExYI4dsOA8uWrtQ5KAvS+17oGQIm+XZx3dUWvTb1r/fQF2EcpC/0leoDP6TIBMI44v HmSQ== X-Forwarded-Encrypted: i=1; AHgh+RrQpaZRXg2XAqocF68itXhtRd7RckrqQKZN8B854XLcq+ErbJnxF8XTcHiCh2L2nLshV5o=@vger.kernel.org X-Gm-Message-State: AOJu0YwkPHz7TiJel05ZYXKpzOy8TzWM/YZGuWcjfLrTP/hFPCDEjtmS vcAODZFKXaq26cCCUIIAfcJpSVK7ZjZZpOUbX61eBe44J6J4Idf4v8nn X-Gm-Gg: AfdE7cmMEZQ017B9vRiWhRb4MenoiV1tTOTuBIHKjNqOW2bATRw4llLOqp9Vi92aXSU u4voWR3pRA4rzfd4XvNAruPGsZ8nTpfGcgp+smVInTE/W3IQ5c9cE8sPkGSmmJGEt1GKliXSoI+ enHL2bJDXV2fvwp7MjX3SEIuUSMegW+Jd69Z3tPE3KUE1f62E5QMRq54O8kpMNyFKh5XabsA/jA 1FEYmXB22Le8cRXFMzIAyyYcgwjica+bmHXsCHGhIV7Ms7Qvc9H8acUCP1KzjQYqtkjn+CTDU9U qT2zyQgFY3QuxvP5yIzz9AQSAhLDbCcqSZ7pmrOX94Jr5BiegqbXu2+NiJis89PGzPvMUebSnvy 0n96jIojdjfSJ6QHQaM1r66dMoNc2n89s8oWQMvNIkZ7SHOFuyyycRW3yrkLZ5hzfp+g3XAGCFL TeSAo63Y+0yMqZhEGEXVBtikknGOiSB7qBBz+Nj/yTShUxYW1d X-Received: by 2002:a17:90b:5683:b0:381:fa5:5217 with SMTP id 98e67ed59e1d1-38e4b5d7cbemr8249330a91.7.1784474561728; Sun, 19 Jul 2026 08:22:41 -0700 (PDT) Received: from localhost.localdomain ([14.218.106.255]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e4aff1cd3sm4364278a91.6.2026.07.19.08.22.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 08:22:41 -0700 (PDT) From: Chengfeng Ye To: Eric Dumazet , Neal Cardwell , Kuniyuki Iwashima , John Fastabend , Jakub Sitnicki , Jiayuan Chen , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Simon Horman , Daniel Borkmann , Alexei Starovoitov , bpf@vger.kernel.org (open list:BPF [L7 FRAMEWORK] (sockmap)) Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chengfeng Ye , stable@vger.kernel.org Subject: [PATCH] bpf, sockmap: Fix sk_redir use-after-free in send verdict Date: Sun, 19 Jul 2026 23:22:07 +0800 Message-ID: <20260719152207.2892156-1-nicoyip.dev@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit sk_psock_msg_verdict() takes a socket reference for psock->sk_redir. tcp_bpf_send_verdict() copies that pointer while holding the source socket lock, but does not take a reference for the local copy before dropping the lock around tcp_bpf_sendmsg_redir(). When apply_bytes keeps the cached verdict active, another sendmsg() on the same source socket can consume the remaining bytes and release the cached reference while the first thread still holds only the raw local pointer: CPU 0 CPU 1 sk_redir = psock->sk_redir apply_bytes remains nonzero release_sock(sk) lock_sock(sk) apply_bytes reaches zero psock->sk_redir = NULL release_sock(sk) tcp_bpf_sendmsg_redir(sk_redir) sock_put(sk_redir) tcp_bpf_sendmsg_redir(sk_redir) The final sock_put() can free sk_redir before CPU 0 dereferences it. KASAN reported: BUG: KASAN: slab-use-after-free in tcp_bpf_sendmsg_redir+0xf39/0x1020 Read of size 8 at addr ffff888108537090 by task poc/87 Call Trace: tcp_bpf_sendmsg_redir+0xf39/0x1020 tcp_bpf_sendmsg+0x977/0x1a50 __sys_sendto+0x32c/0x3a0 __x64_sys_sendto+0xdb/0x1b0 Allocated by task 85: sk_prot_alloc+0x56/0x210 sk_clone+0x6f/0x14b0 inet_csk_clone_lock+0x24/0x740 tcp_create_openreq_child+0x25/0x2710 tcp_v4_syn_recv_sock+0x10a/0xe00 Freed by task 0: __kasan_slab_free+0x43/0x70 slab_free_after_rcu_debug+0xa6/0x1e0 rcu_core+0x50a/0x1850 Last potentially related work creation: __sk_destruct+0x3da/0x540 sk_psock_destroy+0x81e/0xab0 process_one_work+0x63a/0x1070 Take a temporary socket reference while the source socket lock still protects psock->sk_redir, and drop it after tcp_bpf_sendmsg_redir() returns. This keeps each unlocked use independent of cached-verdict ownership. Fixes: 604326b41a6f ("bpf, sockmap: convert to generic sk_msg interface") Cc: stable@vger.kernel.org Signed-off-by: Chengfeng Ye --- net/ipv4/tcp_bpf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv4/tcp_bpf.c b/net/ipv4/tcp_bpf.c index 8e905b50dead..69cc8bc33bcd 100644 --- a/net/ipv4/tcp_bpf.c +++ b/net/ipv4/tcp_bpf.c @@ -469,6 +469,7 @@ static int tcp_bpf_send_verdict(struct sock *sk, struct sk_psock *psock, case __SK_REDIRECT: redir_ingress = psock->redir_ingress; sk_redir = psock->sk_redir; + sock_hold(sk_redir); sk_msg_apply_bytes(psock, tosend); if (!psock->apply_bytes) { /* Clean up before releasing the sock lock. */ @@ -489,6 +490,7 @@ static int tcp_bpf_send_verdict(struct sock *sk, struct sk_psock *psock, if (eval == __SK_REDIRECT) sock_put(sk_redir); + sock_put(sk_redir); lock_sock(sk); sk_mem_uncharge(sk, sent); -- 2.43.0