From: sashiko-bot@kernel.org
To: "Varun R Mallya" <varunrmallya@gmail.com>
Cc: bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v3 6/6] riscv, bpf: Remove BPF exceptions from denylist
Date: Wed, 22 Jul 2026 14:08:43 +0000 [thread overview]
Message-ID: <20260722140843.911B71F00A3E@smtp.kernel.org> (raw)
In-Reply-To: <20260722140015.1982158-7-varunrmallya@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Deleting `DENYLIST.riscv64` breaks the explicit testing instructions provided in `README.rst`.
--
--- Patch [6]: [PATCH bpf-next v3 6/6] riscv, bpf: Remove BPF exceptions from denylist ---
commit e62702d45ea21775bb10258f8620e8e53e10eee4
Author: Varun R Mallya <varunrmallya@gmail.com>
riscv, bpf: Remove BPF exceptions from denylist
This patch removes BPF exceptions from the riscv64 denylist in BPF selftests
and deletes the file entirely since it is now empty.
> diff --git a/tools/testing/selftests/bpf/DENYLIST.riscv64 b/tools/testing/selftests/bpf/DENYLIST.riscv64
> deleted file mode 100644
> index ca1beae7fe8f1..0000000000000
> --- a/tools/testing/selftests/bpf/DENYLIST.riscv64
> +++ /dev/null
[Severity: Low]
Will deleting this file break the manual testing instructions provided in
tools/testing/selftests/bpf/README.rst?
The documentation explicitly uses cat on this file to assemble the vmtest.sh
command:
tools/testing/selftests/bpf/README.rst:
tools/testing/selftests/bpf/vmtest.sh \
-l <path of local rootfs image> -- \
./test_progs -d \
"$(cat tools/testing/selftests/bpf/DENYLIST.riscv64 \
| cut -d'#' -f1 \
...
Since running this example command will now result in a shell error due to the
missing file, should tools/testing/selftests/bpf/README.rst be updated in this
commit to remove or adjust the reference?
> @@ -1,2 +0,0 @@
> -# riscv64 deny list for BPF CI and local vmtest
> -exceptions # JIT does not support exceptions
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260722140015.1982158-1-varunrmallya@gmail.com?part=6
prev parent reply other threads:[~2026-07-22 14:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 14:00 [PATCH bpf-next v3 0/6] Add BPF Exceptions support for RISC-V Varun R Mallya
2026-07-22 14:00 ` [PATCH bpf-next v3 1/6] riscv: Use arch_stack_walk() for the kernel callchain Varun R Mallya
2026-07-22 14:00 ` [PATCH bpf-next v3 2/6] riscv, stacktrace: Pass sp and fp to the walk_stackframe() callback Varun R Mallya
2026-07-22 14:18 ` sashiko-bot
2026-07-22 14:00 ` [PATCH bpf-next v3 3/6] riscv, stacktrace: Implement arch_bpf_stack_walk() for BPF Varun R Mallya
2026-07-22 14:17 ` sashiko-bot
2026-07-22 14:00 ` [PATCH bpf-next v3 4/6] riscv, bpf: Split prologue and epilogue into helper functions Varun R Mallya
2026-07-22 14:00 ` [PATCH bpf-next v3 5/6] riscv, bpf: Add support for BPF exceptions Varun R Mallya
2026-07-22 15:28 ` bot+bpf-ci
2026-07-22 14:00 ` [PATCH bpf-next v3 6/6] riscv, bpf: Remove BPF exceptions from denylist Varun R Mallya
2026-07-22 14:08 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722140843.911B71F00A3E@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=varunrmallya@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox