From: Ning Ding <dingning04@gmail.com>
To: bpf@vger.kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
eddyz87@gmail.com, memxor@gmail.com, martin.lau@linux.dev,
davem@davemloft.net, greg@kroah.com
Subject: [PATCH bpf v2 0/2] bpf: Fix refcount_acquire handling for borrowed kptrs
Date: Sun, 26 Jul 2026 16:50:28 -0700 [thread overview]
Message-ID: <20260726235030.1152542-1-dingning04@gmail.com> (raw)
This series fixes two bugs in bpf_refcount_acquire() verifier handling.
Patch 1 fixes return-value tracking. The verifier can treat an
RCU-loaded borrowed map kptr as owning and mark the return value
non-NULL. At runtime, bpf_refcount_acquire() can still return NULL,
allowing an unchecked NULL value to reach bpf_obj_drop() and crash the
kernel.
Patch 2 fixes argument validation. After bpf_rcu_read_unlock(), the
pointer is PTR_UNTRUSTED, but the verifier still allows it to be passed
to bpf_refcount_acquire(). A reproducer with only CAP_BPF acquired a
reference through this stale pointer after the original object was
dropped and its address was reused.
The series adds verifier regression tests for both cases.
Changes since v1:
- Patch 1 is unchanged.
- Added Patch 2 to reject PTR_UNTRUSTED refcounted kptr inputs after
bpf_rcu_read_unlock().
- Reused the refcount-only selftest fixture introduced by Patch 1.
- Added fail-before/pass-after verifier validation and CAP_BPF-only
runtime confirmation.
Link: https://lore.kernel.org/r/20260726015330.705259-1-dingning04@gmail.com
Ning Ding (2):
bpf: Keep refcount_acquire nullable for borrowed RCU kptrs
bpf: Reject untrusted pointers in refcount_acquire
kernel/bpf/verifier.c | 7 +-
.../selftests/bpf/progs/refcounted_kptr.c | 61 +++++++++++++++
.../bpf/progs/refcounted_kptr_fail.c | 74 +++++++++++++++++++
3 files changed, 141 insertions(+), 1 deletion(-)
--
2.43.0
next reply other threads:[~2026-07-26 23:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-26 23:50 Ning Ding [this message]
2026-07-26 23:50 ` [PATCH bpf v2 1/2] bpf: Keep refcount_acquire nullable for borrowed RCU kptrs Ning Ding
2026-07-27 4:50 ` Greg KH
2026-07-26 23:50 ` [PATCH bpf v2 2/2] bpf: Reject untrusted pointers in refcount_acquire Ning Ding
2026-07-27 0:13 ` sashiko-bot
2026-07-27 0:40 ` Ning Ding
2026-07-27 4:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260726235030.1152542-1-dingning04@gmail.com \
--to=dingning04@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=greg@kroah.com \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox