From: sashiko-bot@kernel.org
To: "Bobby Eshleman" <bobbyeshleman@gmail.com>
Cc: bpf@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: drv-net: enable devmem TCP in the test config
Date: Sat, 01 Aug 2026 23:36:41 +0000 [thread overview]
Message-ID: <20260801233642.1CA131F00AC4@smtp.kernel.org> (raw)
In-Reply-To: <20260731-selftests-devmem-config-v1-1-098014348d9d@meta.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Adding `CONFIG_NET_DEVMEM=y` to the config fragment is ineffective because `NET_DEVMEM` is a hidden symbol with no prompt.
--
--- Patch [1]: [PATCH net-next] selftests: drv-net: enable devmem TCP in the test config ---
commit 07d433d344dd104ff54b719b50d995dfb8a6b2be
Author: Bobby Eshleman <bobbyeshleman@meta.com>
selftests: drv-net: enable devmem TCP in the test config
This commit updates the selftests network hardware config fragment to enable
CONFIG_SYNC_FILE to satisfy dependencies for DMA_SHARED_BUFFER, and explicitly
adds CONFIG_NET_DEVMEM.
> diff --git a/tools/testing/selftests/drivers/net/hw/config b/tools/testing/selftests/drivers/net/hw/config
> index ed8642b68094f..d89a9ba176558 100644
> --- a/tools/testing/selftests/drivers/net/hw/config
> +++ b/tools/testing/selftests/drivers/net/hw/config
> @@ -15,11 +15,13 @@ CONFIG_IPV6_SIT=y
> CONFIG_IPV6_TUNNEL=y
> CONFIG_NET_CLS_ACT=y
> CONFIG_NET_CLS_BPF=y
> +CONFIG_NET_DEVMEM=y
[Severity: Low]
Is this assignment effective? Since NET_DEVMEM is a hidden config symbol
(defined with def_bool y and no prompt string in net/Kconfig), Kconfig
silently ignores manual assignments in config fragments.
It should be automatically enabled when its dependencies are satisfied
(which the addition of CONFIG_SYNC_FILE helps achieve), making this
explicit entry redundant.
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260731-selftests-devmem-config-v1-1-098014348d9d@meta.com?part=1
prev parent reply other threads:[~2026-08-01 23:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 23:36 [PATCH net-next] selftests: drv-net: enable devmem TCP in the test config Bobby Eshleman
2026-08-01 23:36 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260801233642.1CA131F00AC4@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bobbyeshleman@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox