From: chenyuan_fl@163.com
To: bpf@vger.kernel.org
Cc: Quentin Monnet <qmo@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Yuan Chen <chenyuan@kylinos.cn>
Subject: [PATCH bpf-next v3 0/3] bpftool: fix batch file handling issues
Date: Mon, 10 Aug 2026 15:33:45 +0800 [thread overview]
Message-ID: <20260810073348.2586225-1-chenyuan_fl@163.com> (raw)
From: Yuan Chen <chenyuan@kylinos.cn>
This series fixes three issues in bpftool's batch file handling:
1. map dump closes the map fd twice (introduced by the map-by-name
dump refactor).
2. do_batch() reports a spurious read failure because a stale errno
from a previously executed command is used instead of checking the
FILE stream state.
3. (new in v3) a line longer than the batch buffer that contains a '#'
within the buffered prefix bypasses the line length check: the
comment stripping truncates the buffer before the length is
checked, so the unread remainder of the line is parsed and executed
as a separate command on the next loop iteration.
Changes in v3:
- Add patch 3 fixing the pre-existing comment-stripping bypass of the
batch line length check, as pointed out in review of v2.
Changes in v2:
- Patch 2 now uses ferror() to detect read failures and tracks an
overlong line explicitly instead of relying on errno; Fixes tag
corrected to 71bb428fe2c1.
Yuan Chen (3):
bpftool: fix double close in map dump
bpftool: fix spurious batch file read error
bpftool: Fix bypass of the batch line length check by comments
tools/bpf/bpftool/main.c | 12 +++++++++---
tools/bpf/bpftool/map.c | 1 -
2 files changed, 9 insertions(+), 4 deletions(-)
--
2.54.0
next reply other threads:[~2026-08-10 7:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 7:33 chenyuan_fl [this message]
2026-08-10 7:33 ` [PATCH bpf-next v3 1/3] bpftool: fix double close in map dump chenyuan_fl
2026-08-10 8:17 ` bot+bpf-ci
2026-08-10 7:33 ` [PATCH bpf-next v3 2/3] bpftool: fix spurious batch file read error chenyuan_fl
2026-08-10 8:32 ` bot+bpf-ci
2026-08-10 7:33 ` [PATCH bpf-next v3 3/3] bpftool: Fix bypass of the batch line length check by comments chenyuan_fl
2026-08-10 7:42 ` sashiko-bot
2026-08-10 8:32 ` bot+bpf-ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810073348.2586225-1-chenyuan_fl@163.com \
--to=chenyuan_fl@163.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chenyuan@kylinos.cn \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=memxor@gmail.com \
--cc=qmo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox