Re: [PATCH bpf-next v1 1/2] bpf: Verify global subprogs in each sleepability context

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] BPF subsystem multi-line comment style violation.
--

commit aea430d1f0450a56e5505b581236a015c8f1396b
Author: Kumar Kartikeya Dwivedi <memxor@gmail.com>

bpf: Verify global subprogs in each sleepability context

This commit updates the BPF verifier to independently verify global
subprograms across different sleepability contexts, rather than relying
on the sleepable state of the main program. It modifies do_check_subprogs
to track and iteratively verify contexts as they propagate through
asynchronous callbacks.

> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index 5b51e7ee1a3f9..4b9aa0f168bb5 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c

[ ... ]

> @@ -19749,45 +19756,54 @@ static int do_check_subprogs(struct bpf_verifier_env *env)

[ ... ]

> -	/* We can't loop forever as we verify at least one global subprog on
> -	 * each pass.
> +	/* We can't loop forever as each pass verifies at least one new context,
> +	 * and there are only two contexts per global subprog.
>  	 */
>  	if (new_cnt)
>  		goto again;

[Severity: Low]
Does this new comment block violate the preferred multi-line comment style
for the BPF subsystem? The official style mandates that multi-line comments
should place the opening /* on its own line before the text begins.

Could it be reformatted to look like this instead?

/*
 * We can't loop forever as each pass verifies at least one new context,
 * and there are only two contexts per global subprog.
 */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260905034018.2095649-1-memxor@gmail.com?part=1