Re: [PATCH bpf-next 2/2] selftests/bpf: Check bpftool batch map dump contents

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Multi-line comment does not follow the required BPF subsystem style.
--

commit c56ab936d02afbcb53a4b6f2e304647318354a05
Author: Tianyi Chen <hi@tychen.cc>

selftests/bpf: Check bpftool batch map dump contents

This commit adds selftests to exercise bpftool hash map dumps using batches.
It compares the unordered key/value results against expected inputs in plain,
JSON, and pretty JSON formats.

> diff --git a/tools/testing/selftests/bpf/prog_tests/bpftool_map_batch.c b/tools/testing/selftests/bpf/prog_tests/bpftool_map_batch.c
> new file mode 100644
> index 0000000000000..139d13a49dcef
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/prog_tests/bpftool_map_batch.c

[ ... ]

> +static void check_dump(const struct dump_case *test, __u32 id, bool json, bool pretty)
> +{

[ ... ]

> +	err = get_bpftool_command_output(command, output, OUTPUT_SIZE);
> +	if (!ASSERT_OK(err, "map_dump"))
> +		goto out;
> +	/* Ignore presentation whitespace, but compare complete records and all
> +	 * punctuation. Expected contents come only from the input data, never
> +	 * from another map walk or bpftool invocation.
> +	 */

[Severity: Low]
Could we update this multi-line comment in check_dump() to follow the
preferred BPF subsystem style where the opening /* is placed on its own line?

> +	for (src = output, dst = output; *src; src++)
> +		if (!isspace((unsigned char)*src))
> +			*dst++ = *src;
> +	*dst = '\0';

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260906170819.1212661-1-hi@tychen.cc?part=2