Re: [PATCH v7 2/3] perf tools: make the GTK4 report browser actually loadable at runtime

[sashiko-bot@kernel.org]

> perf report --gtk dlopen()s libperf-gtk.so, which expects to resolve
> symbols back against the running perf binary (callchain_param,
> symbol_conf, evsel__name, and friends live in perf, not the plugin).
> Two things broke that after the GTK 4 port:
> 
> perf never passed -rdynamic, so none of its symbols were in its
> dynamic symbol table for a dlopen()ed plugin to find. Add -rdynamic to
> LDFLAGS when GTK4 support is enabled.
> 
> annotated_source__hist_entry() was a static inline in annotate.h, so
> ui/gtk/annotate.c calling it pulled hashmap__find()'s expansion,
> hashmap_find(), into libperf-gtk.so as an undefined symbol. The only
> hashmap_find perf links against normally is libbpf's internal one
> (tools/lib/bpf/hashmap.c), built with -fvisibility=hidden, so it can
> never be exported to a dlopen()ed plugin regardless of LDFLAGS. Move
> annotated_source__hist_entry() into annotate.c as an ordinary exported
> function, so the plugin depends on it the same way it already depends
> on evsel__group_desc() and friends.
> 
> With both fixes, a default 'make GTK4=1' build (libbpf statically
> linked) can dlopen() libperf-gtk.so and open the report browser without
> NO_LIBBPF=1 or manual LDFLAGS. Verified with perf report --gtk against
> real perf.data on a GTK4 desktop.
> 
> Signed-off-by: Matt Turner <mattst88@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260906-perf-gtk2-v7-0-1ece839fbca0@gmail.com?part=2