From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC4663ACF06 for ; Tue, 8 Sep 2026 06:55:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788850546; cv=none; b=EMABr6FyUWSD26zNnly9xWra14kuy9UFwob9a2OPcUBFGkVpaELrZmaP97vSzFhu7Hm3qzTNYKhXM367/b6bP74sUyWw58HwLiQXYBLNmnxaR22IpPPCAK4kGpmJk/dSkvTtJPkigveCBjcwIRZ/1yFxjZ1KE4oI0Vm9jI4QhmA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788850546; c=relaxed/simple; bh=LHPzAlc8bILs7jY8teDdNipJXPplhcsjWjskBzf2tiI=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=I/er3fN0hAjsrK9+Mdy2rTqMoldrrfHOXRzB29SXPSfs6QmEOKvMJH+jDMkVTBu8f231tlbvB6iNAOtjeIspK1lI16d5ffZb5gE1rAuBTvpyWu0mrGunnVWxQfEiHOR3ouC7+Yh8vhfV8Mv1RyYrFAzboOq4hx+e73Ml6SJeIX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--tweek.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=eQ51Qgxa; arc=none smtp.client-ip=209.85.215.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--tweek.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eQ51Qgxa" Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cc1b8088203so4742476a12.3 for ; Mon, 07 Sep 2026 23:55:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1788850543; x=1789455343; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:mime-version:date:from:to:cc:subject:date:message-id :reply-to:content-type; bh=jmwDSdN5PavmzgFMeFCPPTTofQkLr1hsp/PukBG6zPM=; b=eQ51QgxaT5FIh0+g6UOcTTiS2RWsr++CSD5Sj+xgYvCNMgJyq6n+bGeyr8+BTI72kT vyTkWx1ZLvGxSdM1vPyWj/nkoJ4GFSdFBW5OyDx1TwSBdXYpXBG/U4yS1sssszvIJO7/ 2As8MMF/UR6pmUInJ45w4yT42s+7wfMHkBLn+1QDpvFHuuyLfTkRLco8xYyYHZAXy+Hy fXMSu/fklhqb4KCjE4EdSaTK74OWtKAPCz46y3+cmYwOJVFGKRrhBIGdsQc7bomB9AhE OtTyOKANsHVTZvRPbjUGJVfO/yKcteUJmtnkJ/tO38FN4Sgelii/m+XPEZCEG9IadJdX W4Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788850543; x=1789455343; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:mime-version:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=jmwDSdN5PavmzgFMeFCPPTTofQkLr1hsp/PukBG6zPM=; b=ScNWppR3T9/0xxeUtZIe8nK0uIAdG/KP20KxREPvVQLI63Nl8hN6AGXgoym2zlDx0+ /8S+kLogPvalf1obgQMHh4qC3xRbUhx/mGFXKuJCDoy/Wv7dAa6/aYpHT43tfAiqnG6n jXB/8HPmtneK9gxeSd1cu7ta7fpdI9lJZSidNROJiGynHrhEpUQsS3lvmeIzyqSfSCEX Tl8191h5zCm+edTSYA0sEp00w2VnJ7ALMPvE4QiHuhqQkdYLyqudsYT8/s4O1wZ+M75I Y8sadBIZgfqCxDKD6X1RTjt83Qp1Ypj1gZK5oUnxqI+crYSTKhr4YxF17xUbttqcd4oc QHNA== X-Forwarded-Encrypted: i=1; AKwUvBxfjjaIQosJ8qs+N54ssnF72J64Ftd3VEqp7w3I3zAy+6cWNLSNrJVFyr1PxeW+0GMy3oE=@vger.kernel.org X-Gm-Message-State: AFuF++mwzRMSntpAdqpbAELrf9sa7rGaRNDNix3mOKsasjr/j/LbP44Q 8G79yKQJtXxR0neDBBta+oWAIJ4W1ayluxjLekPAF+8Ugu4ctA7kTkk2nTZCSpu1DKtmOF4SGrH Nxg== X-Received: from pfbgp6.prod.google.com ([2002:a05:6a00:3b86:b0:853:2b6c:80e0]) (user=tweek job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:338d:b0:857:73e2:9104 with SMTP id d2e1a72fcca58-8616be5fd03mr37247434b3a.20.1788850542626; Mon, 07 Sep 2026 23:55:42 -0700 (PDT) Date: Tue, 8 Sep 2026 16:55:28 +1000 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.55.0.979.g7e5102b832-goog Message-ID: <20260908065529.901593-1-tweek@google.com> Subject: [PATCH bpf-next 1/2] bpftool: Skip non-autoload programs when generating light skeletons From: "=?UTF-8?q?Thi=C3=A9baud=20Weksteen?=" To: Quentin Monnet , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Shuah Khan , "=?UTF-8?q?Thi=C3=A9baud=20Weksteen?=" , KP Singh , Leon Hwang , Emil Tsalapatis Cc: Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Ihor Solodrai , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable When generating a light skeleton (bpftool gen skeleton -L), bpf_object__load() skips loading programs marked as non-autoload (e.g. SEC("?...")), so the generated loader program only records and populates file descriptors for autoloaded programs. Previously, bpftool emitted struct bpf_prog_desc fields, link fields, and attach/detach/destroy functions for all programs in the BPF object, causing the loader program to store subsequent program FDs into incorrect skeleton struct fields when non-autoload programs were present. Skip programs with !bpf_program__autoload(prog) when counting programs and generating progs/links struct fields as well as attach, detach, and destroy functions for light skeletons. Fixes: d510296d331a ("bpftool: Use syscall/loader program in "prog load" an= d "gen skeleton" command.") Signed-off-by: Thi=C3=A9baud Weksteen --- tools/bpf/bpftool/Documentation/bpftool-gen.rst | 4 +++- tools/bpf/bpftool/gen.c | 15 +++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/tools/bpf/bpftool/Documentation/bpftool-gen.rst b/tools/bpf/bp= ftool/Documentation/bpftool-gen.rst index d0a36f442db7..1cdecf3e4fa5 100644 --- a/tools/bpf/bpftool/Documentation/bpftool-gen.rst +++ b/tools/bpf/bpftool/Documentation/bpftool-gen.rst @@ -184,7 +184,9 @@ OPTIONS -L, --use-loader For skeletons, generate a "light" skeleton (also known as "loader" skeleton). A light skeleton contains a loader eBPF program. It does no= t use - the majority of the libbpf infrastructure, and does not need libelf. + the majority of the libbpf infrastructure, and does not need libelf. B= PF + programs marked as non-autoload (e.g., via **SEC("?...")**) are skippe= d and + not included in the generated skeleton. =20 -S, --sign For skeletons, generate a signed skeleton. This option must be used wi= th diff --git a/tools/bpf/bpftool/gen.c b/tools/bpf/bpftool/gen.c index a50540ef6521..0fcfe20ff515 100644 --- a/tools/bpf/bpftool/gen.c +++ b/tools/bpf/bpftool/gen.c @@ -583,6 +583,9 @@ static void codegen_attach_detach(struct bpf_object *ob= j, const char *obj_name) bpf_object__for_each_program(prog, obj) { const char *tp_name; =20 + if (!bpf_program__autoload(prog)) + continue; + codegen("\ \n\ \n\ @@ -629,6 +632,8 @@ static void codegen_attach_detach(struct bpf_object *ob= j, const char *obj_name) ", obj_name); =20 bpf_object__for_each_program(prog, obj) { + if (!bpf_program__autoload(prog)) + continue; codegen("\ \n\ ret =3D ret < 0 ? ret : %1$s__%2$s__attach(skel); \n\ @@ -646,6 +651,8 @@ static void codegen_attach_detach(struct bpf_object *ob= j, const char *obj_name) ", obj_name); =20 bpf_object__for_each_program(prog, obj) { + if (!bpf_program__autoload(prog)) + continue; codegen("\ \n\ skel_closenz(skel->links.%1$s_fd); \n\ @@ -676,6 +683,8 @@ static void codegen_destroy(struct bpf_object *obj, con= st char *obj_name) obj_name); =20 bpf_object__for_each_program(prog, obj) { + if (!bpf_program__autoload(prog)) + continue; codegen("\ \n\ skel_closenz(skel->progs.%1$s.prog_fd); \n\ @@ -1339,6 +1348,8 @@ static int do_skeleton(int argc, char **argv) map_cnt++; } bpf_object__for_each_program(prog, obj) { + if (use_loader && !bpf_program__autoload(prog)) + continue; prog_cnt++; } =20 @@ -1402,6 +1413,8 @@ static int do_skeleton(int argc, char **argv) if (prog_cnt) { printf("\tstruct {\n"); bpf_object__for_each_program(prog, obj) { + if (use_loader && !bpf_program__autoload(prog)) + continue; if (use_loader) printf("\t\tstruct bpf_prog_desc %s;\n", bpf_program__name(prog)); @@ -1415,6 +1428,8 @@ static int do_skeleton(int argc, char **argv) if (prog_cnt + attach_map_cnt) { printf("\tstruct {\n"); bpf_object__for_each_program(prog, obj) { + if (use_loader && !bpf_program__autoload(prog)) + continue; if (use_loader) printf("\t\tint %s_fd;\n", bpf_program__name(prog)); --=20 2.55.0.979.g7e5102b832-goog