BPF List
 help / color / mirror / Atom feed
From: "Cen Zhang (Microsoft Security FORGE Labs)" <cenzhang@linux.microsoft.com>
To: sashiko-reviews@lists.linux.dev
Cc: AutonomousCodeSecurity@microsoft.com, bpf@vger.kernel.org
Subject: Re: [PATCH bpf v2] bpf: Fix NULL pointer dereference in __bpf_sk_storage_map_seq_show
Date: Fri, 11 Sep 2026 11:34:24 -0400	[thread overview]
Message-ID: <20260911153424.7051-1-cenzhang@linux.microsoft.com> (raw)
In-Reply-To: <20260911142808.1B1581F000FF@smtp.kernel.org>

> This is a pre-existing issue, but does assigning the socket pointer to
> ctx.sk ... introduce a use-after-free risk for non-RCU-safe sockets?

Yes. As Amery noted in the v1 discussion, "It looks like a valid issue
that should be addressed in another patch" [1]. It requires separate
handling and is independent of the NULL selem->local_storage dereference
fixed here.

[1] https://lore.kernel.org/all/CAMB2axPQ1LVXNybsPY7RNa+12+7mtLaahvr0vFL-xHf8sbJK8A@mail.gmail.com/

Thanks,
Cen

      reply	other threads:[~2026-09-11 15:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 14:03 [PATCH bpf v2] bpf: Fix NULL pointer dereference in __bpf_sk_storage_map_seq_show Cen Zhang (Microsoft Security FORGE Labs)
2026-09-11 14:24 ` luoxuanqiang
2026-09-11 14:28 ` sashiko-bot
2026-09-11 15:34   ` Cen Zhang (Microsoft Security FORGE Labs) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911153424.7051-1-cenzhang@linux.microsoft.com \
    --to=cenzhang@linux.microsoft.com \
    --cc=AutonomousCodeSecurity@microsoft.com \
    --cc=bpf@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox