Re: [PATCH net-next v2 4/6] netlink: specs: rt-route: describe lwtunnel IP options

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] netlink: specs: missing multi-attr: true for geneve array in rt-route
--

commit feeb3960dd5418925dfc5011791a483d8533a2c6
Author: Hangbin Liu <liuhangbin@kylinos.cn>

netlink: specs: rt-route: describe lwtunnel IP options

Replace binary opts in lwtunnel-ip and lwtunnel-ip6 with a nested
lwtunnel-ip-opts set. Add attribute sets for geneve, vxlan, and erspan
IP options to match linux/lwtunnel.h.

> diff --git a/Documentation/netlink/specs/rt-route.yaml b/Documentation/netlink/specs/rt-route.yaml
> index 86fc52f856bff..4b12a8a586521 100644
> --- a/Documentation/netlink/specs/rt-route.yaml
> +++ b/Documentation/netlink/specs/rt-route.yaml
[ ... ]
> @@ -560,6 +562,62 @@ attribute-sets:
>        -
>          name: link
>          type: u32
> +  -
> +    name: lwtunnel-ip-opts
> +    name-prefix: lwtunnel-ip-opts-
> +    attributes:
> +      -
> +        name: geneve
> +        type: nest
> +        nested-attributes: lwtunnel-ip-opt-geneve

[Severity: Medium]
Will auto-generated userspace Netlink libraries fail to generate requests
with multiple GENEVE options?

The kernel strictly expects multiple distinct LWTUNNEL_IP_OPTS_GENEVE nests
on the request path to configure multiple options. This is parsed via
nla_for_each_attr() in ip_tun_parse_opts():

net/ipv4/ip_tunnel_core.c:ip_tun_parse_opts() {
    ...
		case LWTUNNEL_IP_OPTS_GENEVE:
			if (type && type != IP_TUNNEL_GENEVE_OPT_BIT)
				return -EINVAL;
			opt_len = ip_tun_parse_opts_geneve(nla, info, opts_len,
							   extack);
    ...
}

Without multi-attr: true, auto-generated clients will treat the geneve
attribute as a singular scalar nest (max-items: 1) and restrict requests
to a single option.

Should this attribute specify multi-attr: true to avoid a functional regression
in expressiveness compared to the legacy binary type?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260920-ynl_rt_encap-v2-0-c664a3e726f6@kylinos.cn?part=4