Re: [PATCH bpf-next 14/14] selftests/bpf: Add test for global data of a program in Rust

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] selftests/bpf: missing mandatory ASSERT_OK_PTR validation for manual prog lookup
--

commit 37e64ff11fb20edbe8afb99ff6fe32fab0d64ea7
Author: Alexei Starovoitov <ast@kernel.org>

selftests/bpf: Add test for global data of a program in Rust

This commit introduces a new test demonstrating how libbpf handles .data,
.bss, and .rodata for BPF programs written in Rust. It builds the program
using upstream rustc and evaluates it through the test_progs framework.

> diff --git a/tools/testing/selftests/bpf/prog_tests/data_in_arena.c b/tools/testing/selftests/bpf/prog_tests/data_in_arena.c
> index bccfb0110b94b..d8bc489820b1e 100644
> --- a/tools/testing/selftests/bpf/prog_tests/data_in_arena.c
> +++ b/tools/testing/selftests/bpf/prog_tests/data_in_arena.c
[ ... ]
> +static void test_rust(void)
> +{
> +	const char *file = "./data_in_arena_rust.bpf.o";
> +	struct bpf_object *obj;
[ ... ]
> +	if (!ASSERT_OK(bpf_object__load(obj), "load"))
> +		goto out;
> +	/* libbpf goes on without BTF when the kernel doesn't take it */
> +	ASSERT_GE(bpf_object__btf_fd(obj), 0, "btf_fd");
> +	ASSERT_EQ(run_prog(bpf_object__find_program_by_name(obj, "list_in_data")),
> +		  100 + 20 + 3, "retval");

[Severity: Low]
Is an ASSERT_OK_PTR() check missing for the program lookup here?

The BPF subsystem testing guidelines mandate that manual lookup APIs like
bpf_object__find_program_by_name() must be validated before use. If the
program named "list_in_data" is missing from the object, the lookup returns
NULL. Passing this unvalidated pointer directly to run_prog() will cause
bpf_program__fd(NULL) to fail the test run.

Validating the pointer first would ensure any failure explicitly indicates
the program was not found, rather than reporting an obscure return value
mismatch.

> +out:
> +	bpf_object__close(obj);
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930193127.2181684-1-alexei.starovoitov@gmail.com?part=14