From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B524B4418F2 for ; Tue, 6 Oct 2026 19:26:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791314783; cv=none; b=UPIMSVfPJ/9o/t68fllvmjG7iI9weZTHXvEFTfTzwEt++nQ9UrKA/Qhiglbu9moE8yuKY7mjcDvVB1cqZO7SjnFyGF6P7RKQ9nIanakBvvKnKq5bMsXW3k+l2Z1NyLN58Bhs7oH8yNMltOKAsntzlfxo1L2jKfklnsJKvTGq0vc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791314783; c=relaxed/simple; bh=aWao5GoSyeYsVEnRkw2XxTV0rOFFmhXm36Vs3Xcr6LI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=FrL11IjUwBdmvPZnx+/dubnBJ7DZHqzRU/fRnzH/k23s+iWHChimXkbd+8/9Hzom3XzFAdowZSDRMv0a2g8P/a+DJZ7LSW3gdxSuoXloPIZS/iGKTntLwjefclnt619md3WHFVFXCH+vK5BsKFRS9M4coaHeq0g5TAUSjxDIfqw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--kuniyu.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=YV0RmtFq; arc=none smtp.client-ip=209.85.216.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--kuniyu.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YV0RmtFq" Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3965ba1ba3eso3798841a91.2 for ; Tue, 06 Oct 2026 12:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1791314781; x=1791919581; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nTDws0c/dI7iiZeVn4428bfcEvuk0ywfHmaDzeWTq4s=; b=YV0RmtFq0eitnC9e2xnqLYSfzOKKo7JnL6WI4EkXokRgerMskz5tIYNPZZwQm0YHHf b4ZtQNa02Ha6pt/wr/WwfyYiD7GY8E/FLufMODvwOYZoz/ngznvOTuq3N4Y4GT6rTyBj 2UUqJv+OuxwciTQFUCoz+Tri2uKxAVXANlkYWuIgpelFx45Ep2QjiqDh6D2fSZS1A/Z6 b0bF3yhDhe4byJ2FYp+PKmux+YhfJZTuqwaYR45lsUPY8/Bxns0conJqQHMzY4c4QQ1+ cmrucuGUvX247+gT3/AQHvzJAbqKwsI+6PWXUuJeovD5pl81C9NqNUOZOjADXU12+4VJ eGLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791314781; x=1791919581; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nTDws0c/dI7iiZeVn4428bfcEvuk0ywfHmaDzeWTq4s=; b=ZK8n6iXltTAnPisRpz15L3RGEXVuTwE2ZXDvvirl17RGyf5Z3lC5S/MhLykeFWq07e rB+fow8ZYt/YZPU7Hjaj3xbjCE0MW59UfleW6zC/YcSswT2CMNDnuzQ7uaw957IRZQWL 74ipJgCVPweTxbT5Wbi92nzvh12GJgorLGoy7xF6IKSOT9t0t1dnpdZm/kqte9OieMfB CFP7ef8OMy/Kdg+v4Q1hjyDMHBwkqeaTyc4N0brggkABZWeVLgy3RgbUKiO1ieoMNSJO m18AbHNyO24df5rmsIMSiNcMqJj3QACinLjUvv9U5HbdCyKNoxI++B+wHzaQ3+b61Jxx IZ7g== X-Forwarded-Encrypted: i=1; AKwUvByKOFvPluaHaUj07hIjI9xv0O9Wm7tYvFrQUHgjpv4615tHVx2VorDlrZbTl43Y+4cWVco=@vger.kernel.org X-Gm-Message-State: AFq9FYJAF9wXPp0I/+uggStrDHE+NiSKA+FzVXtXYuqEiDRs2DYFBioJ WZJNm14YQhWeJTLs+Rbnyo3MJukGc6AZfv2EBFznpvmvhKtcpaBaNoxydYcH9gsMICbTHHs2IIw fNMSpCw== X-Received: from pgmm8.prod.google.com ([2002:a05:6a02:5508:b0:cc7:d071:a17f]) (user=kuniyu job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:48c7:b0:3a7:971:7470 with SMTP id 98e67ed59e1d1-3a8a11b47a9mr155394a91.47.1791314780917; Tue, 06 Oct 2026 12:26:20 -0700 (PDT) Date: Tue, 6 Oct 2026 19:24:27 +0000 In-Reply-To: <20261006192601.1875100-1-kuniyu@google.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20261006192601.1875100-1-kuniyu@google.com> X-Mailer: git-send-email 2.56.0.360.g66cac248cb-goog Message-ID: <20261006192601.1875100-2-kuniyu@google.com> Subject: [PATCH v4 bpf-next 01/10] bpf: tcp: Convert deny-list for bpf_{get,set}sockopt() to allow-list. From: Kuniyuki Iwashima To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Kumar Kartikeya Dwivedi Cc: Amery Hung , Yonghong Song , John Fastabend , Stanislav Fomichev , Eric Dumazet , Neal Cardwell , Willem de Bruijn , Tenzin Ukyab , "=?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?=" , Kuniyuki Iwashima , Kuniyuki Iwashima , bpf@vger.kernel.org, netdev@vger.kernel.org, Emil Tsalapatis Content-Type: text/plain; charset="UTF-8" Currently, four bpf_tcp_ops callbacks are not allowed to call bpf_setsockopt() and bpf_getsockopt(). However, the deny-list is fragile, and when a new callback is added, we might re-open a can of worms. [0][1] Let's convert it to allow-list. Note that it can be written as offsetof(,X) <= moff <= offsetof(,Y) but clang can optimise to similar code anyway. Link: https://lore.kernel.org/r/20220929070407.965581-5-martin.lau@linux.dev/ #[0] Link: https://lore.kernel.org/bpf/20260421155804.135786-1-kafai.wan@linux.dev/ #[1] Signed-off-by: Kuniyuki Iwashima Reviewed-by: Emil Tsalapatis Acked-by: Stanislav Fomichev --- net/ipv4/bpf_tcp_ops.c | 39 ++++++++++++++++++++++++--------------- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/net/ipv4/bpf_tcp_ops.c b/net/ipv4/bpf_tcp_ops.c index 681fed642999..1ada3b781bf1 100644 --- a/net/ipv4/bpf_tcp_ops.c +++ b/net/ipv4/bpf_tcp_ops.c @@ -210,6 +210,24 @@ const struct bpf_func_proto bpf_tcp_ops_get_retval_proto = { .ret_type = RET_INTEGER, }; +static bool is_sockopt_supported(u32 moff) +{ + switch (moff) { + case offsetof(struct bpf_tcp_ops, active_established): + case offsetof(struct bpf_tcp_ops, passive_established): + case offsetof(struct bpf_tcp_ops, rto): + case offsetof(struct bpf_tcp_ops, rtt): + case offsetof(struct bpf_tcp_ops, set_state): + case offsetof(struct bpf_tcp_ops, retrans): + case offsetof(struct bpf_tcp_ops, connect): + case offsetof(struct bpf_tcp_ops, listen): + case offsetof(struct bpf_tcp_ops, parse_hdr): + return true; + } + + return false; +} + static const struct bpf_func_proto * get_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog) { @@ -221,22 +239,13 @@ get_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog) case BPF_FUNC_sk_storage_delete: return &bpf_sk_storage_delete_proto; case BPF_FUNC_setsockopt: - /* The sk may be an unlocked listener (synack path) or NULL - * fullsock; disable for members that can run unlocked. - */ - if (moff == offsetof(struct bpf_tcp_ops, rwnd_init) || - moff == offsetof(struct bpf_tcp_ops, timeout_init) || - moff == offsetof(struct bpf_tcp_ops, hdr_opt_len) || - moff == offsetof(struct bpf_tcp_ops, write_hdr_opt)) - return NULL; - return &bpf_sk_setsockopt_proto; + if (is_sockopt_supported(moff)) + return &bpf_sk_setsockopt_proto; + return NULL; case BPF_FUNC_getsockopt: - if (moff == offsetof(struct bpf_tcp_ops, rwnd_init) || - moff == offsetof(struct bpf_tcp_ops, timeout_init) || - moff == offsetof(struct bpf_tcp_ops, hdr_opt_len) || - moff == offsetof(struct bpf_tcp_ops, write_hdr_opt)) - return NULL; - return &bpf_sk_getsockopt_proto; + if (is_sockopt_supported(moff)) + return &bpf_sk_getsockopt_proto; + return NULL; case BPF_FUNC_get_retval: if (moff == offsetof(struct bpf_tcp_ops, timeout_init) || moff == offsetof(struct bpf_tcp_ops, rwnd_init)) -- 2.56.0.360.g66cac248cb-goog