From: Simon Horman <horms@kernel.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: netdev-bot+sashiko@kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
andrew+netdev@lunn.ch, ast@kernel.org, daniel@iogearbox.net,
davem@davemloft.net, edumazet@kernel.org, hawk@kernel.org,
john.fastabend@gmail.com, kuba@kernel.org, pabeni@redhat.com,
sdf@fomichev.me, sgoutham@marvell.com
Subject: Re: [PATCH v19 net-next 1/2] octeontx2: use atomic bitops for PF/VF and rep flags
Date: Tue, 13 Oct 2026 11:55:41 +0100 [thread overview]
Message-ID: <20261013105541.GA83879@horms.kernel.org> (raw)
In-Reply-To: <asxR6rpmf9b2by4O@rkannoth-OptiPlex-7090>
On Mon, Oct 12, 2026 at 08:50:10AM +0530, Ratheesh Kannoth wrote:
> On 2026-10-10 at 15:31:08, netdev-bot+sashiko@kernel.org (netdev-bot+sashiko@kernel.org) wrote:
> > Thank you for your contribution! Sashiko AI review found 2 potential
> > issue(s) to consider.
> >
> > Critical: 0 · High: 1 (3) · Medium: 1 (5) · Low: 0 (1)
> >
> > If you believe none of the issues are legitimate, please reply to each
> > issue of Medium severity or higher and explain why the AI is wrong.
> > If any of them are legitimate and you plan to respin, please let patchwork
> > know by including "pw-bot: cr" as a separate line at the end of your reply
> > (one such reply per series is enough).
> >
> > - [High] otx2_sync_flags_from_rep() (otx2_common.h:625-634) updates the
> > shared priv->flags word with a plain read-modify-write:…
> Pre-exisisting issues.
>
> > - [Medium] The commit message presents this as a cleanup to atomic
> > bitops, but the patch also fixes a user-visible representor bug and…
> This is side effect of the fix, not intended one.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-10-13 10:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 9:43 [PATCH v19 net-next 0/2] octeontx2: mqprio bandwidth offload for NIX TX schedulers Ratheesh Kannoth
2026-10-06 9:43 ` [PATCH v19 net-next 1/2] octeontx2: use atomic bitops for PF/VF and rep flags Ratheesh Kannoth
2026-10-07 9:44 ` sashiko-bot
2026-10-10 10:01 ` netdev-bot+sashiko
2026-10-12 3:20 ` Ratheesh Kannoth
2026-10-13 10:55 ` Simon Horman [this message]
2026-10-06 9:43 ` [PATCH v19 net-next 2/2] octeontx2: add mqprio bandwidth offload for NIX TX schedulers Ratheesh Kannoth
2026-10-07 9:45 ` sashiko-bot
2026-10-10 10:01 ` netdev-bot+sashiko
2026-10-12 3:50 ` Ratheesh Kannoth
2026-10-13 10:56 ` Simon Horman
2026-10-13 14:05 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013105541.GA83879@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sdf@fomichev.me \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox