From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.78 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793029832; b=sahqnUbCjMassuh/6E4LqxV9DteyvHLaCiNiO1hl9ypyUwj5l9SJ89+FcDRBrHW3Zc8J sdxqVt7p9B9kph/twIQoe/rsnEf34urcQQA4ZkVwRCkXKb82AwvVk7EfInX6q/Yu9UjW5 NqC/07SI3JQmMysU3i6gxuaONoyJGTCyGEaDNnDra9PzWqnQptJ/448+ouVuDZ5S3SMTP DCnREnT91+cmSlFQpVix7M9qnJEQi6obbWPPlsEa7nxnfh9goyzNE3edMZils0gwukPdF DQZnqTtnt8kF3E0w+aKKiv+MogjGNPX6oSKR15/dtkwwzVMOTYHSA+gfOQx0yApbVrg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793029832; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=bPzOvuX5VgrTU9yIIudolJJSPSRHz/AbtYrEX5LP0UI=; b=lxsICVyOs9/p1A9n9f5FqG5m9fSzdU0xUvPYCbd5xATIXlPl/7EyZgu4P3Zt9SM3v3dK q6laDWyKofofN+bezNfie/MoWqdJhRhLiZEDUEJBe4TISO8cAkhUgZ2Ir0J9HWeVWMpel npJN2uqa5F0f4AxZiOrsDcOrtl0BdwUV4MqpeI3iT3SXq7U6pNi8I13wMKYf9iqYNDDry 29/hgGUkwrQOiTjEX/ONCepPM4qXmPH/Nr/160LDC1NBhfbIftc8HJB/MxFfreZ1I9GUJ ehIGEwwJMdECylAT/KVThZi6F7PFNNsRkmcrCS07ommVfvzGK1ZEHDL0RIHIe8Jhnow== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=fLVXW1YC; arc=none smtp.remote-ip=91.218.175.78 Received: from mta0.migadu.com (out-78.mta0.migadu.com [91.218.175.78]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF44E606A31B for ; Mon, 26 Oct 2026 15:50:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org AF44E606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=fLVXW1YC X-Envelope-To: bpf@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=miCtniVHMbA/PYAbgBN5voicnBaPD8dFe3tGyzcmStY=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793029829; v=1; x=1793634629; b=fLVXW1YC5SKbrx587qykDA3NGWr9lE7jFcdNkCrx1cBaIoUmB/DIEwBwqz0J6QrxQIxdTgHC K4Vmz+LUjEWoteH3a9HJ5aCgpKV+kvjIHPkzxVw1LXo9LxODf5NVGoZYgJE08Qfagv6340YhGX7 5GtL7aKwYpchwTUS6akJQRN4= X-Envelope-To: bpf@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id db4da94b28b9c1d8; Mon, 26 Oct 2026 15:50:15 +0000 X-Mizu-Trace-ID: db4da94b28b9c1d8 X-Migadu-Flow: FLOW_OUT From: Leon Hwang To: bpf@vger.kernel.org Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Ihor Solodrai , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Shuah Khan , Kuniyuki Iwashima , Hangbin Liu , Martin Karsten , Masashi Honma , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Leon Hwang Subject: [PATCH bpf-next v5 1/6] bpf: Add syscall common attrs support for link_create Date: Mon, 26 Oct 2026 23:49:42 +0800 Message-ID: <20261026154948.99408-2-leon.hwang@linux.dev> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261026154948.99408-1-leon.hwang@linux.dev> References: <20261026154948.99408-1-leon.hwang@linux.dev> X-Mailing-List: bpf@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Similar to the syscall common attrs support for map_create [1], add the syscall common attrs support for link_create. Create and finalize the internal verifier log instance. Then, report the error messages for invalid prog fd, invalid attach type, and invalid prog type. Links: [1] https://lore.kernel.org/bpf/20260514004634.3DA09C19425@smtp.kernel.org/ Link: https://lore.kernel.org/bpf/20260514004634.3DA09C19425@smtp.kernel.org/ Signed-off-by: Leon Hwang --- kernel/bpf/syscall.c | 35 ++++++++++++++++++++++++++++------- 1 file changed, 28 insertions(+), 7 deletions(-) diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c index 90bc7230afa8..db870e795d04 100644 --- a/kernel/bpf/syscall.c +++ b/kernel/bpf/syscall.c @@ -5862,8 +5862,11 @@ static int bpf_map_do_batch(const union bpf_attr *attr, } #define BPF_LINK_CREATE_LAST_FIELD link_create.uprobe_multi.path_fd -static int link_create(union bpf_attr *attr, bpfptr_t uattr) +static int link_create(union bpf_attr *attr, bpfptr_t uattr, struct bpf_common_attr *attr_common, + bpfptr_t uattr_common, u32 size_common) { + struct bpf_verifier_log *log; + struct bpf_log_attr attr_log; struct bpf_prog *prog; int ret; @@ -5873,14 +5876,24 @@ static int link_create(union bpf_attr *attr, bpfptr_t uattr) if (attr->link_create.attach_type == BPF_STRUCT_OPS) return bpf_struct_ops_link_create(attr); + log = bpf_log_attr_create_vlog(&attr_log, attr_common, uattr_common, size_common); + if (IS_ERR(log)) + return PTR_ERR(log); + prog = bpf_prog_get(attr->link_create.prog_fd); - if (IS_ERR(prog)) - return PTR_ERR(prog); + if (IS_ERR(prog)) { + bpf_log(log, "Invalid prog_fd.\n"); + ret = PTR_ERR(prog); + prog = NULL; + goto out; + } ret = bpf_prog_attach_check_attach_type(prog, attr->link_create.attach_type); - if (ret) + if (ret) { + bpf_log(log, "Invalid attach_type.\n"); goto out; + } switch (prog->type) { case BPF_PROG_TYPE_CGROUP_SKB: @@ -5959,12 +5972,20 @@ static int link_create(union bpf_attr *attr, bpfptr_t uattr) ret = bpf_uprobe_multi_link_attach(attr, prog); break; default: + bpf_log(log, "Invalid prog type.\n"); ret = -EINVAL; } out: - if (ret < 0) - bpf_prog_put(prog); + if (ret < 0) { + int err; + + err = bpf_log_attr_finalize(&attr_log, log); + ret = err ? err : ret; + if (prog) + bpf_prog_put(prog); + } + kfree(log); return ret; } @@ -6536,7 +6557,7 @@ static int __sys_bpf(enum bpf_cmd cmd, bpfptr_t uattr, unsigned int size, err = bpf_map_do_batch(&attr, uattr.user, BPF_MAP_DELETE_BATCH); break; case BPF_LINK_CREATE: - err = link_create(&attr, uattr); + err = link_create(&attr, uattr, &attr_common, uattr_common, size_common); break; case BPF_LINK_UPDATE: err = link_update(&attr); -- 2.55.0