From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.69 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793051577; b=iGk5WbmNPSyxNIaLvRfBXZB+jxgCqz7l86325CaPK2XAJ6uV1LKj/L2lAGSirXHbk6gX 93mq/B8IHUMhfuZuUIRv6SZeX5+o55MI37fslBPTtTP28tbIU7W7ZEKsrD1RY2TFSSd4x biISlE4s3TEM16pyUIjeZDiqCHgmBTdO4Fz1k3gse90G6xqtt370EhgsQQ2pA4Wgg84PU RzPA0j6ZTAe02NGzVOAZDDL4zOrYT6v0yrozaXO0h5DB5FFLgntr2KvRow3DySBagGm5O rmkAxdCNOKJnGwFlWCUeHruTrPe5v5XThXLvKhKv63AikqkXzpchdToiL7X6Z1uMV5Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793051577; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=HQqGCLRyEFq1Qmw7LfzuGpexsFHiUvTKIyODgPSn6eE=; b=fS7EaDQ2s2ZWq5M9I5uUIltDE68nVN32yWXN4ktRvrZhXe5Qf7itegr9XVGurSMTMtp5 pcu0Yrv6sKGEYpyY7l6wcRgvO2viB/K7yxByWT7uNRCGElS96MqS1dci5Ox9js0+sBeof FD2pvseaSY4Q+Ah4l/I39PHKZzZ7ErOcTLSwBxsAaLaCRsJ1jZuHxGvM5Mp1iFiphqXZx JBLFD+uzq/MoiCg3mqkRWXDrRtxBr0omynXE4eiibMlEMh4z51Jdhqkf122k2G5NOg10L Nby23G498q7ryWgSGF/OC2/GiJBIvWMsPeAG6hzp7q5AtanLytkd0z1LK4+NHpQUNZw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--jthoughton.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=ZslLM7db; arc=none smtp.remote-ip=209.85.216.69 Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23DD6606B4D5 for ; Mon, 26 Oct 2026 21:52:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 23DD6606B4D5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jthoughton.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=ZslLM7db Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3abfcf726dcso5159073a91.2 for ; Mon, 26 Oct 2026 14:52:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1793051576; x=1793656376; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HQqGCLRyEFq1Qmw7LfzuGpexsFHiUvTKIyODgPSn6eE=; b=ZslLM7dbmVgAFSoPUZOqKRrOoyj122fasUGdKYfOjOXbcRPiRB7feP6J+Octqg8Oa7 CYkNSyaJ5iygpnvzIZzKMr56CyR1UQjGhD0SeSiR+jnjKI891alYSFsfCdQyY1fP7lfK jjHyo984JGh2+H77mvNAAdFd04oUnBl94P2xuFqBjmjJW2DRxyJuLJmIcvB/faohDtvh cqjWch4Zsyk+B3JEvHSIHxZJLF7Wuqc+8XgYW91lxZJfWyN17H1WnMId3q2wh0N/6TLC csdE1br/thP+JMpWf4qCqC7rGrBz4jRcA0dSFFpspmprnoJ9hiOa+NbLKfXhqIJIfOQ1 +hfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793051576; x=1793656376; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HQqGCLRyEFq1Qmw7LfzuGpexsFHiUvTKIyODgPSn6eE=; b=HgqHoNOOmHCEeQxZoyIEF+DLKhXoe5LcaKT0f9/N7ysxNgZokl9Q0uMwyFSfdUzBtP w9iFUcgYAitdPr/V9YZJZbQX6Lnqqx0mjpZ0bkvLNxR+oHwR/0yJ2SyMeXmbdEVZfKAx vy8GrWLACu5PM6CrAjySEdXYv9+Y6H8aQ5wE3TH/bqVdvaPML5CWZISlWN90jDy7eFB5 yY8MlaSMCtbUgOpH/EKDJhA9CH8Thn1DKla6yAHry2yMcApL40v0orXWYqSfKCZi5tkP +GwAewLCh/sX5PwD/K+nxDcX5ICBc8kDA1Ja2r4ceiAk3ubmkF+kk4BihhZkA02W8mg8 SrXw== X-Forwarded-Encrypted: i=1; AKwUvByn9ylohcvGD2grW0852DWjfdpP5XLHSH94gdCaFI7ddSHBbmlUxlTXSnX0u7rovLX/K48=@vger.kernel.org X-Gm-Message-State: AFq9FYI9Wf4bJ0NMzTLPIzIdYawReuHHSqH/wsKDPI1XYvLkK6bITb9/ ZjArnxIzBM6rzVeWp+bdPNiYTKDIi25l1RIZwb5XPo47dW2L+aSL02eG++EWsYeaCxOICCeXk3F B4wTDGjK7vFTH5ra+WHHLww== X-Received: from pjbst6.prod.google.com ([2002:a17:90b:1fc6:b0:3ac:989f:b65f]) (user=jthoughton job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:1a92:b0:3a8:211b:6c8c with SMTP id 98e67ed59e1d1-3adeaae6e15mr7057279a91.22.1793051576336; Mon, 26 Oct 2026 14:52:56 -0700 (PDT) Date: Mon, 26 Oct 2026 21:52:26 +0000 In-Reply-To: <20261026215226.3713941-1-jthoughton@google.com> X-Mailing-List: bpf@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261026215226.3713941-1-jthoughton@google.com> X-Mailer: git-send-email 2.56.0.307.g5fe7bd680c-goog Message-ID: <20261026215226.3713941-11-jthoughton@google.com> Subject: [RFC PATCH 10/10] uaccess: Move the NULL mm warning out of line From: James Houghton To: Andrew Morton , Alexander Viro Cc: Thomas Gleixner , Peter Zijlstra , Kees Cook , Arnd Bergmann , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Sean Christopherson , Paolo Bonzini , Jim Mattson , Jens Axboe , Pavel Begunkov , "James E.J. Bottomley" , "Martin K. Petersen" , David Sterba , Chris Mason , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Josh Poimboeuf , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, io-uring@vger.kernel.org, linux-scsi@vger.kernel.org, linux-btrfs@vger.kernel.org, bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, James Houghton Content-Type: text/plain; charset="UTF-8" uaccess_without_mm() is inlined into every user copy, including every copy_{to,from}_user() call site on architectures that define INLINE_COPY_USER, such as arm64. Each inlined WARN_ON_ONCE() adds its own __bug_table entry. Keep the NULL current->mm check inline, but move the warning into a single out-of-line, __cold function, uaccess_warn_without_mm(). The trade-off is that only the first offending access in the system warns, rather than the first one from each call site. The stack trace still identifies the caller, and the access is refused either way. Compared to the base of this series, with defconfig + KVM: inline WARN_ON_ONCE() out-of-line warning x86_64 total +5,884 B (+0.014%) +9,714 B (+0.023%) arm64 total +40,948 B (+0.10%) +24,609 B (+0.06%) On arm64, this removes the ~16 KB of __bug_table growth, while text size is unchanged, as a call is the same size as the inline brk. On x86_64, the call is larger than the inline ud2 and causes more .cold splitting, so this is a slight regression. Signed-off-by: James Houghton --- NOTE: This patch is included for reference only, to show the cost of the inline warning. --- include/linux/uaccess.h | 8 +++++++- lib/usercopy.c | 6 ++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/include/linux/uaccess.h b/include/linux/uaccess.h index 7d26d2de9599..6a5b6c2b3388 100644 --- a/include/linux/uaccess.h +++ b/include/linux/uaccess.h @@ -66,9 +66,15 @@ * that keeps user addresses belonging to a specific mm must check * current->mm against that mm itself (see e.g. KVM's kvm->mm checks). */ +void __cold uaccess_warn_without_mm(void); + static __always_inline bool uaccess_without_mm(void) { - return WARN_ON_ONCE(!current->mm); + if (likely(current->mm)) + return false; + /* Warn out of line to keep inlined user copies small. */ + uaccess_warn_without_mm(); + return true; } /* diff --git a/lib/usercopy.c b/lib/usercopy.c index 9146c729c47a..3d547ecb74df 100644 --- a/lib/usercopy.c +++ b/lib/usercopy.c @@ -26,6 +26,12 @@ unsigned long _copy_to_user(void __user *to, const void *from, unsigned long n) EXPORT_SYMBOL(_copy_to_user); #endif +void __cold uaccess_warn_without_mm(void) +{ + WARN_ON_ONCE(1); +} +EXPORT_SYMBOL(uaccess_warn_without_mm); + /** * check_zeroed_user: check if a userspace buffer only contains zero bytes * @from: Source address, in userspace. -- 2.56.0.307.g5fe7bd680c-goog