From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793874298; b=K6LKyisbkgloEeJ6mOmC3mV2/kzGEHE0MqxLtv/16TsqNWBhPF81SQFmrxYqRAvbuYS9 cV86AMjQZ5bcJIgSd7QHu7A59R+UT3bPIrhuqj4hyqtUIQlEEdQMQDlALgCFkRY4IvZ0O hfqpHUucj9hDk1J+KbUnRmufc+4Y2iaGOMjUatP8f1PYZIKioF/nTJFDbTIZJZ6s9Sybx +x4mfTP+/TZwmyQpgU8bN9GbinRNIDmXedIeDjhK16/ZdGWUZId5+0YnzOZMfN5BfLDQ2 Ud8UwrhaB5b/nQw1u44Yq3hHzFutG6txx5MndeS6VG72WB2xr0yHpcXG8j1E/9zPnaQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793874298; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=23ng1jtXqbPnFi3StrOSufGDp6iqJUyj1xh//wWDQPo=; b=W2FeTBcex/xOndEchBN5YiP1cRwCrO84hLWvwg9Z51z366Z5phhK4U4L1Sg1vX0p2zJn CqpXfMaGEgrU/qXpnznoK3e9ha0BrEj+wQ4bmBFz58CgkBfRdW0rZmCv28fuLPPw4mtv1 YmIiz4p3Ha5DYBt7w2JtTZeLPrxx+DcNsfJy+KNoTfaJKX4xeHkxAsLsOsK+gcMdQ65qU aekBHRS6IirD4K9hbtOUzqw4mrWxjPDJLJONcRfBfGSbc5WCSsSppLyYlR+MGKTyrKegZ zcsJ4qWn6aF16ZH0xgKUzJyFE6hxELgzjiv3WS8IL9Jo6WD1t2PWwzSXg2p+UaMRg7A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KjbRlMzY; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9E65606A326 for ; Thu, 5 Nov 2026 10:24:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KjbRlMzY Received: by smtp.kernel.org (Postfix) with ESMTPSA id 047B21F000C1; Thu, 5 Nov 2026 10:24:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793874297; bh=23ng1jtXqbPnFi3StrOSufGDp6iqJUyj1xh//wWDQPo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=KjbRlMzYFvcHjALOFoeiCTDzuUdWwc9I7rztJZwQGTI9YKTrxzwgirkVazUlE1pZf 1gMM/KUkWEUHyOL/oTDopv8zCeBXbpZNgj2AwYUV6SoSzwLk3xvT+wWkHrZ58pom3S e/XuXig5TCA+WHbK0Zv8ylo+q5y6QzGLxaqZj//35/R5nboVBn+TJQv19Cno6DDa6W HTxYSgWmuTVJ7svsot+J2dkvDnHklUdtbSRBHnnvLi6ljuNk5nKdev0kLGLjk5FCnz aQ8nRyl/ejaTF82A9pvzFFkvj5d7NmhTlO2uJl7bxjLf2g6uJ5Q6cAWXN/TCF0JTYC uQp0kK+rjBygQ== From: Jiri Olsa To: Alexei Starovoitov , Daniel Borkmann Cc: bpf@vger.kernel.org, linux-mm@kvack.org, Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Lorenzo Stoakes , John Fastabend , Federico Di Pierro Subject: [PATCHv3 bpf-next 7/8] selftests/bpf: Test bpf_copy_to_user kfunc Date: Thu, 5 Nov 2026 11:23:41 +0100 Message-ID: <20261105102343.311331-8-jolsa@kernel.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261105102343.311331-1-jolsa@kernel.org> References: <20261105102343.311331-1-jolsa@kernel.org> X-Mailing-List: bpf@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Test that bpf_copy_to_user can fault in a paged-out page and write to a read-only mapping. Also verify that a partial copy crossing into an unmapped page returns -EFAULT while leaving the copied byte in place. Assisted-by: Codex:GPT-6 Signed-off-by: Jiri Olsa --- .../selftests/bpf/prog_tests/user_mem.c | 106 ++++++++++++++++++ tools/testing/selftests/bpf/progs/user_mem.c | 17 +++ 2 files changed, 123 insertions(+) diff --git a/tools/testing/selftests/bpf/prog_tests/user_mem.c b/tools/testing/selftests/bpf/prog_tests/user_mem.c index e1748ffb1edf..f13aff73c9bf 100644 --- a/tools/testing/selftests/bpf/prog_tests/user_mem.c +++ b/tools/testing/selftests/bpf/prog_tests/user_mem.c @@ -11,8 +11,11 @@ enum { USER_MEM_MMAP = 1, USER_MEM_UNMAP, USER_MEM_COPY_INSNS, + USER_MEM_COPY, }; +static const char data[] = "fault-enabled BPF write"; + static noinline void user_mem_trigger(void) { asm volatile ("" ::: "memory"); @@ -101,6 +104,18 @@ static bool user_mem_copy_insns(struct user_mem *skel, unsigned long addr) return ASSERT_OK(skel->bss->ret, "user_write"); } +static int user_mem_copy(struct user_mem *skel, unsigned long addr, + u32 size, u64 flags) +{ + skel->bss->user_addr = addr; + skel->bss->copy_size = size; + skel->bss->copy_flags = flags; + skel->bss->action = USER_MEM_COPY; + user_mem_trigger(); + + return skel->bss->ret; +} + static void test_execute_user_page(struct user_mem *skel) { long page_size = sysconf(_SC_PAGESIZE); @@ -162,6 +177,91 @@ static void test_partial_exec(struct user_mem *skel) munmap((void *)addr, page_size * 3); } +static void test_faultable_write(struct user_mem *skel) +{ + long page_size = sysconf(_SC_PAGESIZE); + unsigned long addr = ~0UL; + unsigned char vec; + int i; + + if (!user_mem_mmap(skel, page_size, PROT_READ | PROT_WRITE, &addr)) + return; + + /* Make sure there is a private resident page to page out. */ + memset((void *)addr, 0, page_size); + + /* Retry pageout until mincore confirms that the page is no longer resident. */ + for (i = 0; i < 500; i++) { + if (madvise((void *)addr, page_size, MADV_PAGEOUT)) { + test__skip(); + goto out; + } + if (!ASSERT_OK(mincore((void *)addr, page_size, &vec), "mincore")) + goto out; + if (!(vec & 1)) + break; + usleep(100); + } + if (i == 500) { + test__skip(); + goto out; + } + + /* ..and do the copy to it. */ + if (!ASSERT_OK(user_mem_copy(skel, addr, sizeof(data), 0), "user_write_data")) + goto out; + + ASSERT_EQ(memcmp((void *)addr, data, sizeof(data)), 0, "written_data"); + +out: + if (addr != ~0UL) + munmap((void *)addr, page_size); +} + +static void test_copy_to_readonly_mapping(struct user_mem *skel) +{ + long page_size = sysconf(_SC_PAGESIZE); + unsigned long addr = ~0UL; + + if (!user_mem_mmap(skel, page_size, PROT_READ, &addr)) + return; + + /* Assert we can copy to read-only mapping. */ + if (!ASSERT_OK(user_mem_copy(skel, addr, sizeof(data), 0), "readonly_copy")) + goto out; + + ASSERT_EQ(memcmp((void *)addr, data, sizeof(data)), 0, "readonly_copy_data"); + +out: + if (addr != ~0UL) + munmap((void *)addr, page_size); +} + +static void test_partial_copy_fault(struct user_mem *skel) +{ + long page_size = sysconf(_SC_PAGESIZE); + bool second_page_unmapped = false; + unsigned long addr = ~0UL; + + if (!user_mem_mmap(skel, page_size * 2, PROT_READ | PROT_WRITE, &addr)) + return; + + if (!user_mem_munmap(skel, addr + page_size, page_size)) + goto out; + + second_page_unmapped = true; + + ASSERT_EQ(user_mem_copy(skel, addr + page_size - 1, sizeof(data), 0), + -EFAULT, "partial_copy"); + + /* The byte before the fault stays written. */ + ASSERT_EQ(((char *)addr)[page_size - 1], 'f', "partial_copy_data"); + +out: + if (addr != ~0UL) + munmap((void *)addr, second_page_unmapped ? page_size : page_size * 2); +} + void test_user_mem(void) { struct user_mem *skel; @@ -180,6 +280,12 @@ void test_user_mem(void) test_execute_user_page(skel); if (test__start_subtest("partial_exec")) test_partial_exec(skel); + if (test__start_subtest("faultable_write")) + test_faultable_write(skel); + if (test__start_subtest("copy_to_readonly_mapping")) + test_copy_to_readonly_mapping(skel); + if (test__start_subtest("partial_copy_fault")) + test_partial_copy_fault(skel); out: user_mem__destroy(skel); diff --git a/tools/testing/selftests/bpf/progs/user_mem.c b/tools/testing/selftests/bpf/progs/user_mem.c index 3bbd5d2f02d6..e12a19fc8784 100644 --- a/tools/testing/selftests/bpf/progs/user_mem.c +++ b/tools/testing/selftests/bpf/progs/user_mem.c @@ -17,6 +17,7 @@ enum { USER_MEM_MMAP = 1, USER_MEM_UNMAP, USER_MEM_COPY_INSNS, + USER_MEM_COPY, }; int monitored_pid; @@ -27,6 +28,9 @@ unsigned long user_addr; unsigned long map_len; unsigned long map_prot; +u64 copy_flags; +u32 copy_size; + #if defined(__TARGET_ARCH_x86) static const unsigned char insns[] = { 0xf3, 0x0f, 0x1e, 0xfa, /* endbr64 */ @@ -43,9 +47,13 @@ static const unsigned char insns[] = { static const unsigned char insns[] = { 0 }; #endif +static const char data[] = "fault-enabled BPF write"; + SEC("uprobe.s//proc/self/exe:user_mem_trigger") int user_mem_test(struct pt_regs *ctx) { + u32 size; + if ((bpf_get_current_pid_tgid() >> 32) != monitored_pid) return 0; @@ -59,6 +67,15 @@ int user_mem_test(struct pt_regs *ctx) case USER_MEM_COPY_INSNS: ret = bpf_copy_to_user((void *)user_addr, insns, sizeof(insns), 0); break; + case USER_MEM_COPY: + /* Bound the kfunc length using a local copy of copy_size. */ + size = copy_size; + if (size > sizeof(data)) { + ret = -22; /* -EINVAL */ + break; + } + ret = bpf_copy_to_user((void *)user_addr, data, size, copy_flags); + break; } return 0; -- 2.43.0