From: Jakub Kicinski <kuba@kernel.org>
To: Marcin Knap via B4 Relay <devnull+marcin.knap.vecima.com@kernel.org>
Cc: marcin.knap@vecima.com,
"Tony Nguyen" <anthony.l.nguyen@intel.com>,
"Przemek Kitszel" <przemyslaw.kitszel@intel.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"Simon Horman" <horms@kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
jtollet@cisco.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, "Björn Töpel" <bjorn@kernel.org>,
"Jason Xing" <kerneljasonxing@gmail.com>,
"Nitin Shetty J" <nshettyj@marvell.com>,
"Joshua Washington" <joshwash@google.com>,
"Harshitha Ramamurthy" <hramamurthy@google.com>,
"Sunil Goutham" <sgoutham@marvell.com>,
"Geetha sowjanya" <gakula@marvell.com>,
"Ratheesh Kannoth" <rkannoth@marvell.com>,
"Subbaraya Sundeep" <sbhatta@marvell.com>,
"Bharat Bhushan" <bbhushan2@marvell.com>
Subject: Re: [PATCH net v4] xsk: Do not free ZC Rx buffer when the Rx ring is full
Date: Wed, 11 Nov 2026 17:37:15 -0800 [thread overview]
Message-ID: <20261111173715.75bccc04@kernel.org> (raw)
In-Reply-To: <20261109-xsk-zc-rx-double-free-v4-1-24e00ac221a0@vecima.com>
On Mon, 09 Nov 2026 12:01:14 +0100 Marcin Knap via B4 Relay wrote:
> This covers redirects to an XSKMAP. A zero-copy buffer redirected to
> a devmap or cpumap is copied by xdp_convert_zc_to_xdp_frame(), which
> frees it before the enqueue can still fail. That path is not changed
> here.
But what's the plan for fixing those redirect targets?
I think it'd be much better if we had one series which
addresses all the cases, which AI can review...
If there's consensus that xdp_convert_zc_to_xdp_frame()
can be trivially handled later let's document that (and
how) in the commit message?
--
pw-bot: cr
next prev parent reply other threads:[~2026-11-12 1:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 11:01 [PATCH net v4] xsk: Do not free ZC Rx buffer when the Rx ring is full Marcin Knap via B4 Relay
2026-11-12 1:37 ` Jakub Kicinski [this message]
2026-11-12 7:58 ` Marcin Knap
2026-11-12 10:48 ` Maciej Fijalkowski
2026-11-12 12:01 ` Marcin Knap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111173715.75bccc04@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bbhushan2@marvell.com \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=devnull+marcin.knap.vecima.com@kernel.org \
--cc=edumazet@kernel.org \
--cc=gakula@marvell.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=hramamurthy@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=john.fastabend@gmail.com \
--cc=joshwash@google.com \
--cc=jtollet@cisco.com \
--cc=kerneljasonxing@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=marcin.knap@vecima.com \
--cc=netdev@vger.kernel.org \
--cc=nshettyj@marvell.com \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rkannoth@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sdf@fomichev.me \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox