Re: [PATCH v3 next 05/13] kallsyms: Fix selftest startup delay

[David Laight <david.laight.linux@gmail.com>]

On Wed, 11 Nov 2026 12:36:03 +0000
sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Low] kallsyms: missing Fixes trailer on selftest startup delay fix
> --

Missed because it isn't worth backporting.

David

> 
> commit 06f0c3fe023ccc28da9c2bd9798921899fb0ec63
> Author: David Laight <david.laight.linux@gmail.com>
> 
> > kallsyms: Fix selftest startup delay
> >
> > The kallsym_selftest code clearly intends to sleep until initialisation
> > is complete in order to get more reproducable timings.
> >
> > Replace the schedule_timeout() calls with schedule_timeout_idle()
> > so that the thread actually sleeps.
> > Poll every second (not every 5) for SYSTEM_RUNNING and then wait
> > another 10 seconds before starting the tests, otherwise the tests
> > start as soon an init is executed.
> >
> > This code is in the initial 2022 import of the tests.
> >
> > Signed-off-by: David Laight <david.laight.linux@gmail.com>  
> 
> [Severity: Low]
> Since this fixes the broken schedule_timeout() call from the initial
> selftest import, should it include:
> 
>   Fixes: 30f3bb09778d ("kallsyms: Add self-test facility")
>