From: Tao Cui <cui.tao@linux.dev>
To: tj@kernel.org, josef@toxicopanda.com, axboe@kernel.dk,
ast@kernel.org, alexei.starovoitov@gmail.com
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
andrii@kernel.org, eddyz87@gmail.com, daniel@iogearbox.net,
linux-kselftest@vger.kernel.org, cui.tao@linux.dev,
cuitao@kylinos.cn, ameryhung@gmail.com
Subject: [RFC PATCH v14 2/4] blk-iocost: add iocost_ioc_tick tracepoint for per-period device summary
Date: Wed, 18 Nov 2026 21:10:27 +0800 [thread overview]
Message-ID: <20261118131029.797007-3-cui.tao@linux.dev> (raw)
In-Reply-To: <20261118131029.797007-1-cui.tao@linux.dev>
From: Tao Cui <cuitao@kylinos.cn>
Add iocost_ioc_tick, a tracepoint emitted once per period with a
summary of the controller's overall state.
Observing this state today requires drgn scripts to dig into ioc
internals. Exposing the per-period summary through a tracepoint lets
the common monitoring paths use standard tools (perf, bpftrace)
instead, and gives them an interface that does not shift with the
internal data layout. The emission points and the exact event fields
are documented in include/trace/events/iocost.h.
Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Tao Cui <cuitao@kylinos.cn>
Acked-by: Tejun Heo <tj@kernel.org>
---
MAINTAINERS | 1 +
block/blk-iocost.c | 18 +++++++++++
include/trace/events/iocost.h | 57 +++++++++++++++++++++++++++++++++++
3 files changed, 76 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7d4f4312a2c2..cb9837e3bda7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6910,6 +6910,7 @@ F: block/blk-iocost.c
F: block/blk-iolatency.c
F: block/blk-throttle.c
F: include/linux/blk-cgroup.h
+F: include/trace/events/iocost.h
CONTROL GROUP - CPUSET
M: Waiman Long <longman@redhat.com>
diff --git a/block/blk-iocost.c b/block/blk-iocost.c
index 8398a406f7d3..607f886803b9 100644
--- a/block/blk-iocost.c
+++ b/block/blk-iocost.c
@@ -2378,6 +2378,7 @@ static void ioc_timer_fn(struct timer_list *timer)
struct ioc_now now;
LIST_HEAD(surpluses);
int nr_debtors, nr_shortages = 0, nr_lagging = 0;
+ int nr_active = 0;
u64 usage_us_sum = 0;
u32 ppm_rthr;
u32 ppm_wthr;
@@ -2575,6 +2576,23 @@ static void ioc_timer_fn(struct timer_list *timer)
ioc->busy_level = clamp(ioc->busy_level, -1000, 1000);
+ /*
+ * busy_level, cur_period, nr_active and usage_us_sum are complete
+ * here. usage is wall time over wall time, summed over iocgs, and
+ * is not capped at 100. vrate and period_us reflect the current
+ * controller state, which an io.cost.qos write may have changed
+ * mid-period. Emit before the refresh and the period transition.
+ */
+ if (trace_iocost_ioc_tick_enabled()) {
+ struct ioc_gq *active_iocg;
+
+ list_for_each_entry(active_iocg, &ioc->active_iocgs,
+ active_list)
+ nr_active++;
+
+ trace_iocost_ioc_tick(ioc, &now, nr_active, usage_us_sum);
+ }
+
ioc_adjust_base_vrate(ioc, rq_wait_pct, nr_lagging, nr_shortages,
prev_busy_level, missed_ppm);
diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h
index eb711343ce4f..31df5ed5ee8c 100644
--- a/include/trace/events/iocost.h
+++ b/include/trace/events/iocost.h
@@ -181,6 +181,63 @@ TRACE_EVENT(iocost_ioc_vrate_adj,
)
);
+/*
+ * Periodic per-device summary, emitted once per period before the vrate
+ * adjustment and the period transition in ioc_timer_fn(). Unlike the
+ * state-change events above, this fires every period the controller is
+ * running, including steady states, and one final time before the
+ * controller goes idle, so the transition to dormancy is directly
+ * visible. It carries the overall controller state so basic monitoring
+ * doesn't require drgn.
+ *
+ * vrate is the current vrate in vtime units, where one IO time second
+ * is VTIME_PER_SEC (2^37) vtime and cost.vrate in io.stat reports the
+ * same value as a percentage of that base.
+ *
+ * nr_active is the number of iocgs on the active list when the event
+ * fires, gathered only when the tracepoint is enabled.
+ * usage_pct is the active iocgs' raw usage deltas summed over the period,
+ * as a percentage of the period wall time, the input to debt forgiveness
+ * decisions, before any per-iocg in-flight usage correction (donation
+ * decisions use the per-iocg usage after that correction). It can
+ * exceed 100% when concurrent service-time estimates exceed wall time.
+ */
+TRACE_EVENT(iocost_ioc_tick,
+
+ TP_PROTO(struct ioc *ioc, const struct ioc_now *now,
+ int nr_active, u64 usage_us_sum),
+
+ TP_ARGS(ioc, now, nr_active, usage_us_sum),
+
+ TP_STRUCT__entry (
+ __string(devname, ioc_name(ioc))
+ __field(u64, cur_period)
+ __field(u32, period_us)
+ __field(u64, vrate)
+ __field(int, busy_level)
+ __field(int, nr_active)
+ __field(u64, usage_pct)
+ ),
+
+ TP_fast_assign(
+ __assign_str(devname);
+ __entry->cur_period = atomic64_read(&ioc->cur_period);
+ __entry->period_us = ioc->period_us;
+ __entry->vrate = ioc->vtime_base_rate;
+ __entry->busy_level = ioc->busy_level;
+ __entry->nr_active = nr_active;
+ __entry->usage_pct = now->now > ioc->period_at ?
+ div64_u64(usage_us_sum * 100,
+ now->now - ioc->period_at) : 0;
+ ),
+
+ TP_printk("[%s] period=%llu:%uus vrate=%llu busy=%d active=%d usage=%llu%%",
+ __get_str(devname), __entry->cur_period, __entry->period_us,
+ __entry->vrate, __entry->busy_level, __entry->nr_active,
+ __entry->usage_pct
+ )
+);
+
TRACE_EVENT(iocost_iocg_forgive_debt,
TP_PROTO(struct ioc_gq *iocg, const char *path, struct ioc_now *now,
--
2.53.0
next prev parent reply other threads:[~2026-11-18 13:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 13:10 [RFC PATCH v14 0/4] blk-iocost: BPF struct_ops cost model Tao Cui
2026-11-18 13:10 ` [RFC PATCH v14 1/4] blk-iocost: add BPF struct_ops cost model support Tao Cui
2026-11-18 13:10 ` Tao Cui [this message]
2026-11-18 13:49 ` [RFC PATCH v14 2/4] blk-iocost: add iocost_ioc_tick tracepoint for per-period device summary bot+bpf-ci
2026-11-18 13:10 ` [RFC PATCH v14 3/4] selftests/bpf: add iocost cost model test Tao Cui
2026-11-18 13:41 ` sashiko-bot
2026-11-18 13:49 ` bot+bpf-ci
2026-11-18 13:10 ` [RFC PATCH v14 4/4] docs: cgroup-v2: document the iocost BPF cost model attachment Tao Cui
2026-11-18 13:17 ` [RFC PATCH v14 0/4] blk-iocost: BPF struct_ops cost model Tao Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118131029.797007-3-cui.tao@linux.dev \
--to=cui.tao@linux.dev \
--cc=alexei.starovoitov@gmail.com \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=axboe@kernel.dk \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=cuitao@kylinos.cn \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=josef@toxicopanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox