BPF List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
	michael.chan@broadcom.com, manishc@marvell.com,
	joshwash@google.com, hramamurthy@google.com, tariqt@nvidia.com,
	saeedm@nvidia.com, daniel@iogearbox.net, hawk@kernel.org,
	sdf@fomichev.me, willemb@google.com,
	przemyslaw.kitszel@intel.com, bpf@vger.kernel.org
Subject: Re: [PATCH net-next 3/8] net: state the "XDP excludes HW-GRO" rule in the core
Date: Fri, 20 Nov 2026 14:13:02 -0800	[thread overview]
Message-ID: <20261120141302.5bb2b7ae@kernel.org> (raw)
In-Reply-To: <willemdebruijn.kernel.7756e60d4e06@gmail.com>

On Thu, 19 Nov 2026 17:59:08 -0500 Willem de Bruijn wrote:
> Apparently drivers can enable HW_GRO in some edge case (that can be
> plugged itself?):
> 
>     The rule is only enforced at attach time (dev_xdp_clear_rx_agg). Later
>     recomputes don't re-check after ndo_fix_features. Example:
>       1. Attach a multi-buf XDP program to mlx5 with HDS off. HW-GRO goes off.
>       2. Enable tcp-data-split. rings.c:253 only refuses this for
>          single-buffer XDP, via dev_xdp_sb_prog_count().
>       3. The next feature recompute runs mlx5e_fix_features(), and its
>          "Keeping HW-GRO enabled" block (en_main.c:4643) sets GRO_HW again,
>          after this strip. HW-GRO is now on with XDP attached.
>     This already happens today, but once 5/8 removes mlx5's own XDP check
>     the core is the only guard, and it misses this case. Either add a
>     post-fix_features check here (warn and strip, or refuse the change), or
>     make the HDS-enable path in rings.c refuse while any XDP program is
>     attached and the driver ties HDS to HW-GRO.

Enabling of HDS can't happen in the sequence you describe, driver
checks:

static bool mlx5e_ethtool_set_tcp_data_split(struct mlx5e_priv *priv, 
...
        if (tcp_data_split == ETHTOOL_TCP_DATA_SPLIT_ENABLED &&                 
            !(dev->features & NETIF_F_GRO_HW)) {    

and with XDP attached GRO_HW is not in features (only wanted_features)

Thanks for the reviews, I'll spin v2 before EOD

  reply	other threads:[~2026-11-20 22:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 23:23 [PATCH net-next 0/8] net: adjust HW GRO and LRO feature handling Jakub Kicinski
2026-11-18 23:23 ` [PATCH net-next 1/8] net: stop making HW-GRO depend on SW GRO Jakub Kicinski
2026-11-18 23:23 ` [PATCH net-next 2/8] selftests: drv-net: drop the generic XDP hack from the HW GRO setup Jakub Kicinski
2026-11-19 21:40   ` Willem de Bruijn
2026-11-18 23:23 ` [PATCH net-next 3/8] net: state the "XDP excludes HW-GRO" rule in the core Jakub Kicinski
2026-11-19 22:59   ` Willem de Bruijn
2026-11-20 22:13     ` Jakub Kicinski [this message]
2026-11-18 23:23 ` [PATCH net-next 4/8] net: state the "XDP excludes LRO" " Jakub Kicinski
2026-11-19 23:02   ` Willem de Bruijn
2026-11-19 23:24   ` sashiko-bot
2026-11-18 23:23 ` [PATCH net-next 5/8] eth: mlx5e: drop the now-dead HW-GRO and LRO vs XDP handling Jakub Kicinski
2026-11-19 15:42   ` Dragos Tatulea
2026-11-18 23:23 ` [PATCH net-next 6/8] eth: bnxt_en: don't clear HW-GRO and LRO for XDP in ndo_fix_features Jakub Kicinski
2026-11-18 23:23 ` [PATCH net-next 7/8] eth: qede: drop the now-dead HW-GRO vs XDP handling Jakub Kicinski
2026-11-18 23:23 ` [PATCH net-next 8/8] eth: gve: drop the now-dead HW-GRO vs XDP interlock Jakub Kicinski
2026-11-18 23:44   ` Ankit Garg
2026-11-19 22:14   ` Harshitha Ramamurthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120141302.5bb2b7ae@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=hramamurthy@google.com \
    --cc=joshwash@google.com \
    --cc=manishc@marvell.com \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=saeedm@nvidia.com \
    --cc=sdf@fomichev.me \
    --cc=tariqt@nvidia.com \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox