From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nXjh1ttJ" Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46E31F9 for ; Fri, 17 Nov 2023 10:52:52 -0800 (PST) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-9becde9ea7bso686389266b.0 for ; Fri, 17 Nov 2023 10:52:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700247171; x=1700851971; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=kGf6qpGgfT9GJbaqM684fZfWpGyMYxPC3OQ1djAFW1Y=; b=nXjh1ttJlscr04ziiZK8NFKKGpcD1BstthiuZV2J3+RQLaeTXUaBVFB1mqxWVjWxqI i2/6iKtxSjLUsRMWUaWfC4072ph6zWpC+zP6JUs+ryBCXGIihUmfRBo+KHWSps+2qPEN aVLOO9Hn4QSZ/RUZylHpYfEhSqyCwHZrSjF2iig8J38/CK4pgWPplCw/M+hfoweLo7Rr reqP16tdnwF3QYaTNMQLcf54VdtwdKEhA87JsMCwYucYPj3RilQcqi4+lmGGf7Vd2WZ+ pGh8cwkvks9Ew8NCQtfNDiQF2ddXvoIreaGALZrn+KtCswdlqSUPJQzfzNvxhfCoO73S Adww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700247171; x=1700851971; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kGf6qpGgfT9GJbaqM684fZfWpGyMYxPC3OQ1djAFW1Y=; b=QpZI4vKQiCpt/8Slt13SSX+lDUb7PnQdMfbMHQgjL9aNJ4qaO9EPreLdBZtwuCNtA3 LDokMbf50fShnn8X8JZttQAnWxDPFvfhyu1ApxPFuE45UApxqTQJQH7J2olQB5tvjcmt 0uAmvCbMItd1ha4QON0bDd94vlcs0GtzLsQJUqk0SNYT7NNO+4T26YTKGzxGzq9EbRmZ SksXGGPSQGqQev88WQJ86qz/osq8+uSmRaCJncY9KLDkZbmSyEm+KrodQbgl2K4Hb/tc D9ts9oHlbApp+oXV+3kq7Yk/K0K4hTUpJn3xHk8j2ko//fHfx/C7aNPeismh+fMzngqA edWA== X-Gm-Message-State: AOJu0YxInHVXxfvhLwqRSu5095RK8yinDwFCSXYlNt9LHaAOvF0bc2AH jjTy9+LZAIhLJq0NA/QPYUw= X-Google-Smtp-Source: AGHT+IEur4m5GG2TOyxojDatjtCx/jpGpv6ItMMHRgE34+ApQ4NXyw5gfZxt7RuO9VTfjDiweDfmJg== X-Received: by 2002:a17:906:3b1a:b0:9dd:ce68:a28c with SMTP id g26-20020a1709063b1a00b009ddce68a28cmr5661679ejf.24.1700247170640; Fri, 17 Nov 2023 10:52:50 -0800 (PST) Received: from [192.168.1.95] (host-176-36-0-241.b024.la.net.ua. [176.36.0.241]) by smtp.gmail.com with ESMTPSA id le13-20020a170907170d00b0099bcf9c2ec6sm1061734ejc.75.2023.11.17.10.52.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 10:52:50 -0800 (PST) Message-ID: <21079422c7b3515caeae1e5773cef61359f27000.camel@gmail.com> Subject: Re: [PATCH bpf 05/12] bpf: extract setup_func_entry() utility function From: Eduard Zingerman To: Andrii Nakryiko Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev, kernel-team@fb.com, yonghong.song@linux.dev, memxor@gmail.com, awerner32@gmail.com Date: Fri, 17 Nov 2023 20:52:49 +0200 In-Reply-To: References: <20231116021803.9982-1-eddyz87@gmail.com> <20231116021803.9982-6-eddyz87@gmail.com> Autocrypt: addr=eddyz87@gmail.com; prefer-encrypt=mutual; keydata=mQGNBGKNNQEBDACwcUNXZOGTzn4rr7Sd18SA5Wv0Wna/ONE0ZwZEx+sIjyGrPOIhR14/DsOr3ZJer9UJ/WAJwbxOBj6E5Y2iF7grehljNbLr/jMjzPJ+hJpfOEAb5xjCB8xIqDoric1WRcCaRB+tDSk7jcsIIiMish0diTK3qTdu4MB6i/sh4aeFs2nifkNi3LdBuk8Xnk+RJHRoKFJ+C+EoSmQPuDQIRaF9N2m4yO0eG36N8jLwvUXnZzGvHkphoQ9ztbRJp58oh6xT7uH62m98OHbsVgzYKvHyBu/IU2ku5kVG9pLrFp25xfD4YdlMMkJH6l+jk+cpY0cvMTS1b6/g+1fyPM+uzD8Wy+9LtZ4PHwLZX+t4ONb/48i5AKq/jSsb5HWdciLuKEwlMyFAihZamZpEj+9n91NLPX4n7XeThXHaEvaeVVl4hfW/1Qsao7l1YjU/NCHuLaDeH4U1P59bagjwo9d1n5/PESeuD4QJFNqW+zkmE4tmyTZ6bPV6T5xdDRHeiITGc00AEQEAAbQkRWR1YXJkIFppbmdlcm1hbiA8ZWRkeXo4N0BnbWFpbC5jb20+iQHUBBMBCgA+FiEEx+6LrjApQyqnXCYELgxleklgRAkFAmKNNQECGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQLgxleklgRAlWZAv/cJ5v3zlEyP0/jMKQBqbVCCHTirPEw+nqxbkeSO6r2FUds0NnGA9a6NPOpBH+qW7a6+n6q3sIbvH7jlss4pzLI7LYlDC6z+egTv7KR5X1xFrY1uR5UGs1beAjnzYeV2hK4yqRUfygsT0Wk5e4FiNBv4+DUZ8r0cNDkO6swJxU55DO21mcteC147+4aDoHZ40R0tsAu+brDGSSoOPpb0RWVsEf9XOBJqWWA+T7mluw nYzhLWGcczc6J71q1Dje0l5vIPaSFOgwmWD4DA+WvuxM/shH4rtWeodbv iCTce6yYIygHgUAtJcHozAlgRrL0jz44cggBTcoeXp/atckXK546OugZPnl00J3qmm5uWAznU6T5YDv2vCvAMEbz69ib+kHtnOSBvR0Jb86UZZqSb4ATfwMOWe9htGTjKMb0QQOLK0mTcrk/TtymaG+T4Fsos0kgrxqjgfrxxEhYcVNW8v8HISmFGFbqsJmFbVtgk68BcU0wgF8oFxo7u+XYQDdKbI1uQGNBGKNNQEBDADbQIdo8L3sdSWGQtu+LnFqCZoAbYurZCmUjLV3df1b+sg+GJZvVTmMZnzDP/ADufcbjopBBjGTRAY4L76T2niu2EpjclMMM3mtrOc738Kr3+RvPjUupdkZ1ZEZaWpf4cZm+4wH5GUfyu5pmD5WXX2i1r9XaUjeVtebvbuXWmWI1ZDTfOkiz/6Z0GDSeQeEqx2PXYBcepU7S9UNWttDtiZ0+IH4DZcvyKPUcK3tOj4u8GvO3RnOrglERzNCM/WhVdG1+vgU9fXO83TB/PcfAsvxYSie7u792s/I+yA4XKKh82PSTvTzg2/4vEDGpI9yubkfXRkQN28w+HKF5qoRB8/L1ZW/brlXkNzA6SveJhCnH7aOF0Yezl6TfX27w1CW5Xmvfi7X33V/SPvo0tY1THrO1c+bOjt5F+2/K3tvejmXMS/I6URwa8n1e767y5ErFKyXAYRweE9zarEgpNZTuSIGNNAqK+SiLLXt51G7P30TVavIeB6s2lCt1QKt62ccLqUAEQEAAYkBvAQYAQoAJhYhBMfui64wKUMqp1wmBC4MZXpJYEQJBQJijTUBAhsMBQkDwmcAAAoJEC4MZXpJYEQJkRAMAKNvWVwtXm/WxWoiLnXyF2WGXKoDe5+itTLvBmKcV/b1OKZF1s90V7WfSBz712eFAynEzyeezPbwU8QBiTpZcHXwQni3IYKvsh7s t1iq+gsfnXbPz5AnS598ScZI1oP7OrPSFJkt/z4acEbOQDQs8aUqrd46PV jsdqGvKnXZxzylux29UTNby4jTlz9pNJM+wPrDRmGfchLDUmf6CffaUYCbu4FiId+9+dcTCDvxbABRy1C3OJ8QY7cxfJ+pEZW18fRJ0XCl/fiV/ecAOfB3HsqgTzAn555h0rkFgay0hAvMU/mAW/CFNSIxV397zm749ZNLA0L2dMy1AKuOqH+/B+/ImBfJMDjmdyJQ8WU/OFRuGLdqOd2oZrA1iuPIa+yUYyZkaZfz/emQwpIL1+Q4p1R/OplA4yc301AqruXXUcVDbEB+joHW3hy5FwK5t5OwTKatrSJBkydSF9zdXy98fYzGniRyRA65P0Ix/8J3BYB4edY2/w0Ip/mdYsYQljBY0A== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2023-11-17 at 11:46 -0500, Andrii Nakryiko wrote: [...] > > + /* Transfer references to the callee */ > > + err =3D copy_reference_state(callee, caller); > > + if (err) > > + goto err_out; > > + > > + err =3D set_callee_state_cb(env, caller, callee, callsite); > > + if (err) > > + goto err_out; >=20 > given we are touching and moving this code, it might make sense to > make it a bit more succinct with this pattern: >=20 > err =3D copy_reference_state(...); > err =3D err ?: set_callee_state_cb(); > if (err) > goto err_out; >=20 >=20 > Error handling is a bit less distracting this way. Will do.