From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1402C433EF for ; Fri, 15 Jul 2022 17:15:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229787AbiGORP6 (ORCPT ); Fri, 15 Jul 2022 13:15:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbiGORP5 (ORCPT ); Fri, 15 Jul 2022 13:15:57 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95FF24333F for ; Fri, 15 Jul 2022 10:15:55 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id 8-20020a05600c024800b003a2fe343db1so3415734wmj.1 for ; Fri, 15 Jul 2022 10:15:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=fpicviDv92d17eZ1c7+rexcLir2xBn7O3KmN0Kzxfro=; b=UsPBSJRfmKSsPNeL3N72N6j2SQUo01hlJU2ux3y9cLehp6fsxKs1PXgrJZ+cz7Gmgb JkNqaSxCMH9nf6fZP14uguh+M5eHFTqBe6JhJYpBo/J2GzbsZfW1UzY+B0CIiTW9Dqvy qLAjdjctG+wbU9nkMzarTluwuO8Sc9dBpW9PqkG73uNVF/ZiTZ29ttfNsGaX7p/yhIOs La2uu/vzBds0lAHxILy5ujM+HvwGG4V3b+LLpBTuBrUJZkYT1LJ42Gj8u1VtSvl13FaU ADF/qRTPaXxXALqTN+FH4PQCGGHoqAjCE39skMtpYo4L+AEocC65M356N/dyODgDhADt cKNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=fpicviDv92d17eZ1c7+rexcLir2xBn7O3KmN0Kzxfro=; b=XMUViih98Bs3XwVKD+E/uklSx/qK7DYxrwhbUb3yvyYLihQWRcR0YkWfWP3XFpmp0A 4cR3b/mmKijhlmfdwHC9c/Ptv2gb4v+pTwLGhLKodtc73weZYREh+MSbdHcWhyRO9McM Xj/yrG0d/tlW28SxzPpskAMc6jklbQov6f98MMWCsWae9mCxiTbFfI82e2DV8NTB/Dr1 YyTZ0bxUlsQpnT5lSAkm+YvKaCDTbTsZ+0CRRKBMBAFxAtfWqLm07OtqOEMy+Ut10c36 ytgTMoBz07E5fRpurABb2S/p+Fw2FXp8nkdwQG86M9HWXUtZbCQQ3JjQJ/VUGpoCnAjb TOxw== X-Gm-Message-State: AJIora+sPrGPsiFd+MLGVHi7MZ636Ec6Xc9pS0L7dadhkxJksmFX1MN3 4dWTgIB/ZKrMYt4lfvGWcT620w== X-Google-Smtp-Source: AGRyM1srOvCAxL5rNPwCPwV3iadtGRLjhcptNZRRVwLonHjWJkzvBYZ4nYe7xGrUVTV1L4NwYd+qcg== X-Received: by 2002:a1c:750e:0:b0:3a2:b42f:ec2c with SMTP id o14-20020a1c750e000000b003a2b42fec2cmr21460710wmc.153.1657905354184; Fri, 15 Jul 2022 10:15:54 -0700 (PDT) Received: from [192.168.178.32] ([51.155.200.13]) by smtp.gmail.com with ESMTPSA id p19-20020a05600c359300b003a300452f7fsm7847323wmq.32.2022.07.15.10.15.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Jul 2022 10:15:53 -0700 (PDT) Message-ID: <21cec7bd-e4fb-73f7-a6a6-7f52c03ae7e9@isovalent.com> Date: Fri, 15 Jul 2022 18:15:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [PATCH bpf-next v2 0/3] Use lightweigt version of bpftool Content-Language: en-GB To: Andrii Nakryiko , Pu Lehui Cc: bpf , Networking , open list , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Jean-Philippe Brucker References: <20220714024612.944071-1-pulehui@huawei.com> From: Quentin Monnet In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 15/07/2022 17:56, Andrii Nakryiko wrote: > On Wed, Jul 13, 2022 at 7:16 PM Pu Lehui wrote: >> >> Currently, samples/bpf, tools/runqslower and bpf/iterators use bpftool >> for vmlinux.h, skeleton, and static linking only. We can uselightweight >> bootstrap version of bpftool to handle these, and it will be faster. >> >> v2: >> - make libbpf and bootstrap bpftool independent. and make it simple. >> > > Quentin, does this patch set look good to you? [Apologies, the mail server has been filtering Pu's emails as spam for some reason and I had missed the discussion :s] Looks OK to me: Acked-by: Quentin Monnet Although I'm a bit sorry to see the sharing of libbpf between bpftool and libbpf go away. But OK. We can maybe reintroduce it through bpftool's Makefile or a separate include Makefile in the future. Quentin