BPF List
 help / color / mirror / Atom feed
From: Viktor Malik <vmalik@redhat.com>
To: Eduard Zingerman <eddyz87@gmail.com>,
	bpf@vger.kernel.org, ast@kernel.org
Cc: andrii@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev,
	kernel-team@fb.com, yonghong.song@linux.dev
Subject: Re: [PATCH bpf] samples/bpf: pass TPROGS_USER_CFLAGS to libbpf makefile
Date: Thu, 5 Dec 2024 08:07:09 +0100	[thread overview]
Message-ID: <239dadcd-30d5-46a2-a80d-ef184add6b11@redhat.com> (raw)
In-Reply-To: <20241204173416.142240-1-eddyz87@gmail.com>

On 12/4/24 18:34, Eduard Zingerman wrote:
> Before commit [1], the value of a variable TPROGS_USER_CFLAGS was
> passed to libbpf make command as a part of EXTRA_CFLAGS.
> This commit makes sure that the value of TPROGS_USER_CFLAGS is still
> passed to libbpf make command, in order to maintain backwards build
> scripts compatibility.
> 
> [1] commit 5a6ea7022ff4 ("samples/bpf: Remove unnecessary -I flags from libbpf EXTRA_CFLAGS")
> 
> Fixes: 5a6ea7022ff4 ("samples/bpf: Remove unnecessary -I flags from libbpf EXTRA_CFLAGS")
> Suggested-by: Viktor Malik <vmalik@redhat.com>
> Signed-off-by: Eduard Zingerman <eddyz87@gmail.com>

Thanks! Works as expected.

Acked-by: Viktor Malik <vmalik@redhat.com>

> ---
>  samples/bpf/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
> index 96a05e70ace3..dd9944a97b7e 100644
> --- a/samples/bpf/Makefile
> +++ b/samples/bpf/Makefile
> @@ -123,7 +123,7 @@ always-y += ibumad_kern.o
>  always-y += hbm_out_kern.o
>  always-y += hbm_edt_kern.o
>  
> -TPROGS_CFLAGS = $(TPROGS_USER_CFLAGS)
> +COMMON_CFLAGS = $(TPROGS_USER_CFLAGS)
>  TPROGS_LDFLAGS = $(TPROGS_USER_LDFLAGS)
>  
>  ifeq ($(ARCH), arm)


  reply	other threads:[~2024-12-05  7:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-04 17:34 [PATCH bpf] samples/bpf: pass TPROGS_USER_CFLAGS to libbpf makefile Eduard Zingerman
2024-12-05  7:07 ` Viktor Malik [this message]
2024-12-05 18:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=239dadcd-30d5-46a2-a80d-ef184add6b11@redhat.com \
    --to=vmalik@redhat.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=kernel-team@fb.com \
    --cc=martin.lau@linux.dev \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox