From: Leon Hwang <leon.hwang@linux.dev>
To: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Cc: Chengkaitao <pilgrimtao@gmail.com>,
martin.lau@linux.dev, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, eddyz87@gmail.com, song@kernel.org,
yonghong.song@linux.dev, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com,
jolsa@kernel.org, shuah@kernel.org, chengkaitao@kylinos.cn,
linux-kselftest@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v7 5/5] bpf: refactor kfunc checks using table-driven approach in verifier
Date: Wed, 11 Mar 2026 13:36:34 +0800 [thread overview]
Message-ID: <23d2b1c3-aafd-4af1-8511-a74a1cd06ef3@linux.dev> (raw)
In-Reply-To: <CAP01T74Xbg9HiGA6qwPzkOnaq5XfGu_MA+bKX6g-OE9UwOoboQ@mail.gmail.com>
On 11/3/26 04:10, Kumar Kartikeya Dwivedi wrote:
> On Mon, 9 Mar 2026 at 07:45, Leon Hwang <leon.hwang@linux.dev> wrote:
>>
>> On 8/3/26 21:46, Chengkaitao wrote:
>>> From: Kaitao Cheng <chengkaitao@kylinos.cn>
>>>
>>> Replace per-kfunc btf_id chains in list/rbtree/res_lock and graph node
>>> checks with btf_id_in_kfunc_table() and static kfunc tables for easier
>>> maintenance.
>>>
>>
>> Such refactoring should be the first patch? Less churn. Then, update the
>> list only.
>>
>> However, is_bpf_rbtree_api_kfunc(), is_bpf_res_spin_lock_kfunc(), and
>> BPF_RB_NODE should be excluded, because you didn't touch them in this
>> series.
>
> I think moving clean up earlier makes some sense, but why exclude
> rbtree and res spin lock?
> Looks better to me to do them all.
>
Okay. Acceptable for me to keep them.
Thanks,
Leon
prev parent reply other threads:[~2026-03-11 5:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 13:46 [PATCH bpf-next v7 0/5] bpf: Extend the bpf_list family of APIs Chengkaitao
2026-03-08 13:46 ` [PATCH bpf-next v7 1/5] bpf: Introduce the bpf_list_del kfunc Chengkaitao
2026-03-09 6:33 ` Leon Hwang
2026-03-10 20:10 ` Kumar Kartikeya Dwivedi
2026-03-10 20:28 ` Kumar Kartikeya Dwivedi
2026-03-08 13:46 ` [PATCH bpf-next v7 2/5] bpf: Add bpf_list_add_impl to insert node after a given list node Chengkaitao
2026-03-08 14:25 ` bot+bpf-ci
2026-03-09 6:34 ` Leon Hwang
2026-03-10 20:10 ` Kumar Kartikeya Dwivedi
2026-03-08 13:46 ` [PATCH bpf-next v7 3/5] bpf: add bpf_list_is_first/last/empty kfuncs Chengkaitao
2026-03-09 6:42 ` Leon Hwang
2026-03-08 13:46 ` [PATCH bpf-next v7 4/5] selftests/bpf: Add test cases for bpf_list_del/add/is_first/is_last/empty Chengkaitao
2026-03-08 14:25 ` bot+bpf-ci
2026-03-09 6:43 ` Leon Hwang
2026-03-10 2:05 ` Alexei Starovoitov
2026-03-08 13:46 ` [PATCH bpf-next v7 5/5] bpf: refactor kfunc checks using table-driven approach in verifier Chengkaitao
2026-03-09 6:45 ` Leon Hwang
2026-03-10 20:10 ` Kumar Kartikeya Dwivedi
2026-03-11 5:36 ` Leon Hwang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23d2b1c3-aafd-4af1-8511-a74a1cd06ef3@linux.dev \
--to=leon.hwang@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chengkaitao@kylinos.cn \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=pilgrimtao@gmail.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox