From: Yonghong Song <yhs@fb.com>
To: Hao Luo <haoluo@google.com>
Cc: Yosry Ahmed <yosryahmed@google.com>, Tejun Heo <tj@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Johannes Weiner <hannes@cmpxchg.org>,
Shakeel Butt <shakeelb@google.com>,
Stanislav Fomichev <sdf@google.com>,
David Rientjes <rientjes@google.com>, bpf <bpf@vger.kernel.org>,
KP Singh <kpsingh@kernel.org>,
cgroups@vger.kernel.org, Linux-MM <linux-mm@kvack.org>
Subject: Re: [RFC bpf-next] Hierarchical Cgroup Stats Collection Using BPF
Date: Tue, 22 Mar 2022 15:06:41 -0700 [thread overview]
Message-ID: <2453e8f6-29fe-c11a-75a4-18644a68d525@fb.com> (raw)
In-Reply-To: <CA+khW7jFSmm5sTyAVfEZhYnKDhVZKRRGLgAmCqgZzgON8NJOGg@mail.gmail.com>
On 3/22/22 2:37 PM, Hao Luo wrote:
> On Tue, Mar 22, 2022 at 11:09 AM Yonghong Song <yhs@fb.com> wrote:
>>
>> Hi, Yosry, I heard this was discussed in bpf office hour which I
>> didn't attend. Could you summarize the conclusion and what is the
>> step forward? We also have an internal tool which collects cgroup
>> stats and this might help us as well. Thanks!
>>
>
> Hi Yonghong,
>
> Yosry is out of office this entire week. I don't know whether he has
> access to corp email account, so please allow me to reply on his
> behalf.
>
> So instead of using rstat in bpf (by providing a map interface), it's
> better to leverage the flexibility provided by bpf to extend rstat.
> "We can achieve a similar outcome with a less intrusive design." Yosry
> "will look at programs providing their own aggregators and maintaining
> their own stats, and only making callbacks to/from rstat." As the next
> step, Yosry is going to work on an RFC patchset to drive the
> discussion, when he is back.
>
> It's great to see that this is helpful to you as well! I am looking
> forward to collaboration if there is a need.
Thanks, Hao, for explanation. I am looking forward to the RFC patch!
>
> Hao
next prev parent reply other threads:[~2022-03-22 22:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 20:27 [RFC bpf-next] Hierarchical Cgroup Stats Collection Using BPF Yosry Ahmed
2022-03-14 5:35 ` Tejun Heo
2022-03-16 16:35 ` Yosry Ahmed
2022-03-22 18:09 ` Yonghong Song
2022-03-22 21:37 ` Hao Luo
2022-03-22 22:06 ` Yonghong Song [this message]
2022-03-28 9:22 ` Yosry Ahmed
2022-03-16 6:04 ` Song Liu
2022-03-16 16:13 ` Yosry Ahmed
2022-03-16 16:31 ` Tejun Heo
2022-03-18 19:59 ` Song Liu
2022-03-28 9:16 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2453e8f6-29fe-c11a-75a4-18644a68d525@fb.com \
--to=yhs@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hannes@cmpxchg.org \
--cc=haoluo@google.com \
--cc=kpsingh@kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=sdf@google.com \
--cc=shakeelb@google.com \
--cc=tj@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox