public inbox for bpf@vger.kernel.org
 help / color / mirror / Atom feed
From: Eduard Zingerman <eddyz87@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	 patchwork-bot+netdevbpf@kernel.org
Cc: Ihor Solodrai <ihor.solodrai@pm.me>, bpf <bpf@vger.kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii.nakryiko@gmail.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Mykola Lysenko <mykolal@fb.com>
Subject: Re: [PATCH bpf-next v4] selftests/bpf: use auto-dependencies for test objects
Date: Mon, 22 Jul 2024 17:57:38 -0700	[thread overview]
Message-ID: <24a6649743528b2c8f44cc5415df32a3020b0951.camel@gmail.com> (raw)
In-Reply-To: <CAADnVQ+F6JKp1e61NC22wt8L9YEVAz9w648GvdV8hUrM3dkDFA@mail.gmail.com>

On Mon, 2024-07-22 at 17:39 -0700, Alexei Starovoitov wrote:

[...]

> Andrii, Ihor,
> 
> not sure what happened, but 'make clean' now takes forever.
> Pls take a look.

It happens under certain conditions, here is a scenario that behaves
badly for me:
- two branches:
  - 'master' at cca09a371fa7
  - 'tmp' with [0] applied on top of master
- Steps to repro:

    # cd selftests directory
    $ git checkout tmp
    $ git clean -xfd .      # be careful
    $ make -j test_progs
    $ git checkout master
    $ make clean
    
After which output looks as follows:

  CLNG-BPF [test_maps] access_map_in_map.bpf.o
  GEN-SKEL [test_progs] access_map_in_map.skel.h
  CLNG-BPF [test_maps] arena_atomics.bpf.o
  GEN-SKEL [test_progs] arena_atomics.skel.h
  CLNG-BPF [test_maps] arena_htab_asm.bpf.o
  GEN-SKEL [test_progs] arena_htab_asm.skel.h
  CLNG-BPF [test_maps] arena_htab.bpf.o
  GEN-SKEL [test_progs] arena_htab.skel.h
  CLNG-BPF [test_maps] arena_list.bpf.o
  GEN-SKEL [test_progs] arena_list.skel.h
  CLNG-BPF [test_maps] async_stack_depth.bpf.o
  GEN-SKEL [test_progs] async_stack_depth.skel.h
  CLNG-BPF [test_maps] atomic_bounds.bpf.o
  GEN-SKEL [test_progs] atomic_bounds.skel.h
  CLNG-BPF [test_maps] bad_struct_ops2.bpf.o
  GEN-SKEL [test_progs] bad_struct_ops2.skel.h
  CLNG-BPF [test_maps] bad_struct_ops.bpf.o
  GEN-SKEL [test_progs] bad_struct_ops.skel.h
  CLNG-BPF [test_maps] bench_local_storage_create.bpf.o
  GEN-SKEL [test_progs] bench_local_storage_create.skel.h
  CLNG-BPF [test_maps] bind4_prog.bpf.o
  GEN-SKEL [test_progs] bind4_prog.skel.h
  ...

[0] https://lore.kernel.org/bpf/20240719110059.797546-1-xukuohai@huaweicloud.com/


  reply	other threads:[~2024-07-23  0:57 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-18 22:57 [PATCH bpf-next v4] selftests/bpf: use auto-dependencies for test objects Ihor Solodrai
2024-07-19 18:18 ` Andrii Nakryiko
2024-07-19 19:03   ` Ihor Solodrai
2024-07-19 21:54   ` Tony Ambardar
2024-07-19 22:25     ` Andrii Nakryiko
2024-07-19 23:21       ` [PATCH bpf-next v1] selftests/bpf: Fix wrong binary in Makefile log output Tony Ambardar
2024-07-20  0:14         ` bot+bpf-ci
2024-07-20  1:23         ` Eduard Zingerman
2024-07-20  2:57         ` Andrii Nakryiko
2024-07-20  5:23           ` Tony Ambardar
2024-07-23  1:35             ` Tony Ambardar
2024-07-23  1:37               ` Eduard Zingerman
2024-07-23 20:28                 ` Andrii Nakryiko
2024-07-20  5:25         ` [PATCH bpf-next v2] " Tony Ambardar
2024-07-20  5:49           ` bot+bpf-ci
2024-07-22 15:17           ` bot+bpf-ci
2024-07-22 19:58           ` bot+bpf-ci
2024-07-23  1:40           ` bot+bpf-ci
2024-07-23  2:46           ` bot+bpf-ci
2024-07-23 20:30           ` patchwork-bot+netdevbpf
2024-07-19 18:20 ` [PATCH bpf-next v4] selftests/bpf: use auto-dependencies for test objects patchwork-bot+netdevbpf
2024-07-23  0:39   ` Alexei Starovoitov
2024-07-23  0:57     ` Eduard Zingerman [this message]
2024-07-23  1:49       ` Eduard Zingerman
2024-07-23  1:50       ` Ihor Solodrai
2024-07-23 19:25         ` Ihor Solodrai
2024-07-23 20:02           ` Andrii Nakryiko
2024-07-23 20:11             ` Ihor Solodrai
2024-09-13 14:51   ` Björn Töpel
2024-09-13 22:33     ` Ihor Solodrai
2024-09-14 10:54       ` Björn Töpel
2024-09-15  4:47         ` Ihor Solodrai
2024-09-15 15:41           ` Björn Töpel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24a6649743528b2c8f44cc5415df32a3020b0951.camel@gmail.com \
    --to=eddyz87@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=ihor.solodrai@pm.me \
    --cc=mykolal@fb.com \
    --cc=patchwork-bot+netdevbpf@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox