From: Eduard Zingerman <eddyz87@gmail.com>
To: Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
martin.lau@kernel.org
Cc: kernel-team@meta.com
Subject: Re: [PATCH bpf-next 0/3] Two small fixes for global subprog tagging
Date: Fri, 02 Feb 2024 23:27:25 +0200 [thread overview]
Message-ID: <259aafd6cd17cd489236188aa32539b504f71d3c.camel@gmail.com> (raw)
In-Reply-To: <20240202190529.2374377-1-andrii@kernel.org>
On Fri, 2024-02-02 at 11:05 -0800, Andrii Nakryiko wrote:
> Fix a bug with passing trusted PTR_TO_BTF_ID_OR_NULL register into global
> subprog that expects `__arg_trusted __arg_nullable` arguments, which was
> discovered when adopting production BPF application.
>
> Also fix annoying warnings that are irrelevant for static subprogs, which are
> just an artifact of using btf_prepare_func_args() for both static and global
> subprogs.
Full patch-set looks good to me.
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
next prev parent reply other threads:[~2024-02-02 21:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 19:05 [PATCH bpf-next 0/3] Two small fixes for global subprog tagging Andrii Nakryiko
2024-02-02 19:05 ` [PATCH bpf-next 1/3] bpf: handle trusted PTR_TO_BTF_ID_OR_NULL in argument check logic Andrii Nakryiko
2024-02-02 19:05 ` [PATCH bpf-next 2/3] selftests/bpf: add more cases for __arg_trusted __arg_nullable args Andrii Nakryiko
2024-02-02 19:05 ` [PATCH bpf-next 3/3] bpf: don't emit warnings intended for global subprogs for static subprogs Andrii Nakryiko
2024-02-02 21:27 ` Eduard Zingerman [this message]
2024-02-03 2:20 ` [PATCH bpf-next 0/3] Two small fixes for global subprog tagging patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=259aafd6cd17cd489236188aa32539b504f71d3c.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox