From: Eduard Zingerman <eddyz87@gmail.com>
To: Alan Maguire <alan.maguire@oracle.com>,
Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
martin.lau@kernel.org
Cc: kernel-team@meta.com, Mykyta Yatsenko <yatsenko@meta.com>
Subject: Re: [PATCH bpf-next 2/2] libbpf: fix BPF skeleton forward/backward compat handling
Date: Thu, 04 Jul 2024 13:56:36 -0700 [thread overview]
Message-ID: <2b28deafbfdd5cccc0781bb95ebf8a966ceb6c74.camel@gmail.com> (raw)
In-Reply-To: <13891abf-3c88-4369-8fe3-0fb8f5673038@oracle.com>
On Thu, 2024-07-04 at 16:16 +0100, Alan Maguire wrote:
[...]
> Nit: would it be worth dropping a debug logging message here
>
>
> /* Skeleton is created with earlier version of bpftool
> * which does not support auto-attachment
> */
> - if (s->map_skel_sz < sizeof(struct bpf_map_skeleton))
> + if (s->map_skel_sz < sizeof(struct bpf_map_skeleton)) {
> + pr_debug("libbpf version mismatch, cannot auto-attach\n");
> return 0;
> + }
>
> ...as it's a hard issue to spot?
+1 for debug message, but this is not an error condition,
so I'd say something like "..., skipping auto-attach for struct_ops".
next prev parent reply other threads:[~2024-07-04 20:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 0:15 [PATCH bpf-next 0/2] Fix libbpf BPF skeleton forward/backward compat Andrii Nakryiko
2024-07-04 0:15 ` [PATCH bpf-next 1/2] bpftool: improve skeleton backwards compat with old buggy libbpfs Andrii Nakryiko
2024-07-04 19:21 ` Quentin Monnet
2024-07-08 17:14 ` Andrii Nakryiko
2024-07-04 20:31 ` Eduard Zingerman
2024-07-08 17:15 ` Andrii Nakryiko
2024-07-08 17:53 ` Eduard Zingerman
2024-07-04 0:15 ` [PATCH bpf-next 2/2] libbpf: fix BPF skeleton forward/backward compat handling Andrii Nakryiko
2024-07-04 15:16 ` Alan Maguire
2024-07-04 20:56 ` Eduard Zingerman [this message]
2024-07-08 17:19 ` Andrii Nakryiko
2024-07-08 17:19 ` Andrii Nakryiko
2024-07-04 20:51 ` Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b28deafbfdd5cccc0781bb95ebf8a966ceb6c74.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
--cc=martin.lau@kernel.org \
--cc=yatsenko@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox