Re: [PATCH bpf-next v9 1/2] bpftool: Add recursive map dumping

[Quentin Monnet <qmo@kernel.org>]

2026-09-29 02:19 UTC+0900 ~ Tianyi Chen <hi@tychen.cc>
> Hi Quentin,
> 
>> We'll need to fix these, but this should be a
>> different patch or series. You're welcome to go at it if you want, I'll
>> send a patch otherwise, just let me know.
> 
> I've taken care of this in a separate two-patch series:
> https://lore.kernel.org/r/cover.1790615923.git.hi@tychen.cc
> 
> It clears info and resets len before each query in do_show(),
> do_show_subset(), maps_have_btf(), and the existing do_dump() loop.
> The four regression subtests fail before the fix and pass after it.
> 
>> I would maybe move this
>> memset() (the hunk above) to that dedicated patch.
> 
> Done. The resets in the two new recursive-only loops stay with the
> recursive implementation.
> 
>> You still have a conflict with Maxim's series on patch 2 though, both of
>> you picked the same test file name. Maybe use
>> bpftool_map_dump_recursive.c instead?
> 
> Done locally, including renaming the test entry point. I tested against
> Maxim's complete v4 series, keeping his tests intact: all 21 focused
> subtests pass in an x86-64 VM.
> 
> Thanks for the Ack. I'll carry it forward and wait for the prerequisites
> to land before rebasing and resending the recursive series.

Hi Tianyi, Maxim's patch set was merged last week, so could you please
rebase and repost this series, too?

Thanks,
Quentin