From: Eduard Zingerman <eddyz87@gmail.com>
To: puranjay@kernel.org, Yonghong Song <yonghong.song@linux.dev>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
Xu Kuohai <xukuohai@huaweicloud.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next 3/3] selftests/bpf: Add tests for arena fault reporting
Date: Mon, 11 Aug 2025 10:14:02 -0700 [thread overview]
Message-ID: <2c415f65e1af61445606dd4d80ec2750bd9245ff.camel@gmail.com> (raw)
In-Reply-To: <mb61ph5yjgt77.fsf@kernel.org>
On Thu, 2025-08-07 at 13:25 +0000, puranjay@kernel.org wrote:
[...]
> If we don't define BPF_NO_KFUNC_PROTOTYPES then there are build failures
> for bpf_arena_alloc/free_pages() because the prototypes in vmlinux.h
> lack __arena attribute.
What pahole version are you using?
For me these functions are declared as:
extern void __attribute__((address_space(1))) *
bpf_arena_alloc_pages(void *p__map, void __attribute__((address_space(1))) *addr__ign,
u32 page_cnt, int node_id, u64 flags) __weak __ksym;
extern void bpf_arena_free_pages(void *p__map,
void __attribute__((address_space(1))) *ptr__ign,
u32 page_cnt) __weak __ksym;
The __attribute__((address_space(1))) was added relatively recently:
- dwarves commit 40e82f5be9a7 ("pahole: Introduce --btf_feature=attributes")
- kernel commit 21cb33c7e065 ("kbuild, bpf: Enable --btf_features=attributes")
[...]
prev parent reply other threads:[~2025-08-11 17:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 8:58 [PATCH bpf-next 0/3] bpf: Report arena faults to BPF streams Puranjay Mohan
2025-08-06 8:58 ` [PATCH bpf-next 1/3] bpf: arm64: simplify exception table handling Puranjay Mohan
2025-08-06 22:58 ` Yonghong Song
2025-08-06 8:58 ` [PATCH bpf-next 2/3] bpf: Report arena faults to BPF stderr Puranjay Mohan
2025-08-06 23:57 ` Yonghong Song
2025-08-07 13:22 ` puranjay
2025-08-06 8:58 ` [PATCH bpf-next 3/3] selftests/bpf: Add tests for arena fault reporting Puranjay Mohan
2025-08-07 0:04 ` Yonghong Song
2025-08-07 13:25 ` puranjay
2025-08-07 15:25 ` Kumar Kartikeya Dwivedi
2025-08-11 10:35 ` Puranjay Mohan
2025-08-11 20:31 ` Kumar Kartikeya Dwivedi
2025-08-11 17:14 ` Eduard Zingerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c415f65e1af61445606dd4d80ec2750bd9245ff.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=puranjay@kernel.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=will@kernel.org \
--cc=xukuohai@huaweicloud.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).