From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85BE0C6FD1D for ; Fri, 17 Mar 2023 19:42:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229560AbjCQTmT (ORCPT ); Fri, 17 Mar 2023 15:42:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbjCQTmS (ORCPT ); Fri, 17 Mar 2023 15:42:18 -0400 Received: from out-19.mta0.migadu.com (out-19.mta0.migadu.com [91.218.175.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD4CEB77C for ; Fri, 17 Mar 2023 12:42:17 -0700 (PDT) Message-ID: <2cb64258-e566-00c3-7a40-f63e90f3bf97@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1679082135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9cSTv7/C0ADzsHhJ9JS/m7pEJqps65h9S5FJx5x2zWg=; b=JaCdpAWGY20wU8u2IRQ15MW208aYMncGXjdJb9GtjLjRFLI3fLMSduqmLoDpD/yOCIgnoV 8e8bEhtrynkzqnyAw9ze286ZkN1T/VdOTK4h/YMv8RJslRV1h3c9vasvXGFxb6/IZ/jIn1 kmKYZE6OrMu6F8Vanxn4EHXYg3nvHY0= Date: Fri, 17 Mar 2023 12:42:12 -0700 MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v7 6/8] libbpf: Update a bpf_link with another struct_ops. Content-Language: en-US To: Kui-Feng Lee References: <20230316023641.2092778-1-kuifeng@meta.com> <20230316023641.2092778-7-kuifeng@meta.com> Cc: bpf@vger.kernel.org, ast@kernel.org, song@kernel.org, kernel-team@meta.com, andrii@kernel.org, sdf@google.com X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <20230316023641.2092778-7-kuifeng@meta.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 3/15/23 7:36 PM, Kui-Feng Lee wrote: > Introduce bpf_link__update_map(), which allows to atomically update > underlying struct_ops implementation for given struct_ops BPF link > > Signed-off-by: Kui-Feng Lee > --- > tools/lib/bpf/libbpf.c | 30 ++++++++++++++++++++++++++++++ > tools/lib/bpf/libbpf.h | 1 + > tools/lib/bpf/libbpf.map | 1 + > 3 files changed, 32 insertions(+) > > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > index 6dbae7ffab48..63ec1f8fe8a0 100644 > --- a/tools/lib/bpf/libbpf.c > +++ b/tools/lib/bpf/libbpf.c > @@ -11659,6 +11659,36 @@ struct bpf_link *bpf_map__attach_struct_ops(const struct bpf_map *map) > return &link->link; > } > > +/* > + * Swap the back struct_ops of a link with a new struct_ops map. > + */ > +int bpf_link__update_map(struct bpf_link *link, const struct bpf_map *map) > +{ > + struct bpf_link_struct_ops *st_ops_link; > + __u32 zero = 0; > + int err, fd; > + > + if (!bpf_map__is_struct_ops(map) || map->fd < 0) > + return -EINVAL; > + > + st_ops_link = container_of(link, struct bpf_link_struct_ops, link); > + /* Ensure the type of a link is correct */ > + if (st_ops_link->map_fd < 0) > + return -EINVAL; > + > + err = bpf_map_update_elem(map->fd, &zero, map->st_ops->kern_vdata, 0); > + if (err && err != -EBUSY) > + return err; > + > + fd = bpf_link_update(link->fd, map->fd, NULL); bpf_link_update() returns ok/error. Using "fd = ..." is confusing. Use "err = ..." instead and remove the need of "int fd;". > + if (fd < 0) > + return fd; > + > + st_ops_link->map_fd = map->fd; > + > + return 0; > +} > + > typedef enum bpf_perf_event_ret (*bpf_perf_event_print_t)(struct perf_event_header *hdr, > void *private_data); > > diff --git a/tools/lib/bpf/libbpf.h b/tools/lib/bpf/libbpf.h > index db4992a036f8..1615e55e2e79 100644 > --- a/tools/lib/bpf/libbpf.h > +++ b/tools/lib/bpf/libbpf.h > @@ -719,6 +719,7 @@ bpf_program__attach_freplace(const struct bpf_program *prog, > struct bpf_map; > > LIBBPF_API struct bpf_link *bpf_map__attach_struct_ops(const struct bpf_map *map); > +LIBBPF_API int bpf_link__update_map(struct bpf_link *link, const struct bpf_map *map); > > struct bpf_iter_attach_opts { > size_t sz; /* size of this struct for forward/backward compatibility */ > diff --git a/tools/lib/bpf/libbpf.map b/tools/lib/bpf/libbpf.map > index 50dde1f6521e..cc05be376257 100644 > --- a/tools/lib/bpf/libbpf.map > +++ b/tools/lib/bpf/libbpf.map > @@ -387,6 +387,7 @@ LIBBPF_1.2.0 { > global: > bpf_btf_get_info_by_fd; > bpf_link_get_info_by_fd; > + bpf_link__update_map; > bpf_map_get_info_by_fd; > bpf_prog_get_info_by_fd; > } LIBBPF_1.1.0;