From: Eduard Zingerman <eddyz87@gmail.com>
To: Hou Tao <houtao@huaweicloud.com>, bpf@vger.kernel.org
Cc: Martin KaFai Lau <martin.lau@linux.dev>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>, Song Liu <song@kernel.org>,
Hao Luo <haoluo@google.com>,
Yonghong Song <yonghong.song@linux.dev>,
Daniel Borkmann <daniel@iogearbox.net>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Jiri Olsa <jolsa@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
houtao1@huawei.com
Subject: Re: [PATCH bpf-next v3 3/3] selftests/bpf: Test the inlining of bpf_kptr_xchg()
Date: Fri, 05 Jan 2024 15:26:09 +0200 [thread overview]
Message-ID: <2d2ed98e8d4c5386b03f5c04bab7c439c9bbaffa.camel@gmail.com> (raw)
In-Reply-To: <20240105104819.3916743-4-houtao@huaweicloud.com>
On Fri, 2024-01-05 at 18:48 +0800, Hou Tao wrote:
> From: Hou Tao <houtao1@huawei.com>
>
> The test uses bpf_prog_get_info_by_fd() to obtain the xlated
> instructions of the program first. Since these instructions have
> already been rewritten by the verifier, the tests then checks whether
> the rewritten instructions are as expected. And to ensure LLVM generates
> code exactly as expected, use inline assembly and a naked function.
>
> Suggested-by: Eduard Zingerman <eddyz87@gmail.com>
> Signed-off-by: Hou Tao <houtao1@huawei.com>
> ---
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Thank you for this adjustment.
next prev parent reply other threads:[~2024-01-05 13:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 10:48 [PATCH bpf-next v3 0/3] bpf: inline bpf_kptr_xchg() Hou Tao
2024-01-05 10:48 ` [PATCH bpf-next v3 1/3] bpf: Support inlining bpf_kptr_xchg() helper Hou Tao
2024-01-05 10:48 ` [PATCH bpf-next v3 2/3] selftests/bpf: Factor out get_xlated_program() helper Hou Tao
2024-01-05 10:48 ` [PATCH bpf-next v3 3/3] selftests/bpf: Test the inlining of bpf_kptr_xchg() Hou Tao
2024-01-05 13:26 ` Eduard Zingerman [this message]
2024-01-06 2:32 ` Hou Tao
2024-01-05 22:53 ` [PATCH bpf-next v3 0/3] bpf: inline bpf_kptr_xchg() Song Liu
2024-01-06 2:34 ` Hou Tao
2024-01-06 8:51 ` Song Liu
2024-01-12 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d2ed98e8d4c5386b03f5c04bab7c439c9bbaffa.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=houtao1@huawei.com \
--cc=houtao@huaweicloud.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox