From: Yonghong Song <yonghong.song@linux.dev>
To: Sergey Kacheev <s.kacheev@gmail.com>, bpf@vger.kernel.org
Subject: Re: [PATCH v2 bpf-next] libbpf: Use local includes inside the library
Date: Wed, 2 Aug 2023 07:44:17 -0700 [thread overview]
Message-ID: <2e44382b-13a0-5346-c914-be0ae0c7edcd@linux.dev> (raw)
In-Reply-To: <CAJVhQqW6nvWFozMOVQ=_sUTRwVjsQL+G2yCyd91c0bjsc7PcGA@mail.gmail.com>
On 8/2/23 1:05 AM, Sergey Kacheev wrote:
> This patch makes it possible to import the header files of the bpf
> part directly from the source tree.
Could you describe more about your workflow why this patch
is necessary? I would like to understand whether this is a bug
fix for your workflow or something else.
>
> Signed-off-by: Sergey Kacheev <s.kacheev@gmail.com>
> ---
> Changes from v1:
> - Replaced the patch for github/libpf with a patch for bpf-next Linux
> source tree
> Reference:
> - v1: https://lore.kernel.org/bpf/CAJVhQqXomJeO_23DqNWO9KUU-+pwVFoae0Xj=8uH2V=N0mOUSg@mail.gmail.com/
> ---
> tools/lib/bpf/bpf_tracing.h | 2 +-
> tools/lib/bpf/usdt.bpf.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/lib/bpf/bpf_tracing.h b/tools/lib/bpf/bpf_tracing.h
> index be076a404..3803479db 100644
> --- a/tools/lib/bpf/bpf_tracing.h
> +++ b/tools/lib/bpf/bpf_tracing.h
> @@ -2,7 +2,7 @@
> #ifndef __BPF_TRACING_H__
> #define __BPF_TRACING_H__
>
> -#include <bpf/bpf_helpers.h>
> +#include "bpf_helpers.h"
>
> /* Scan the ARCH passed in from ARCH env variable (see Makefile) */
> #if defined(__TARGET_ARCH_x86)
> diff --git a/tools/lib/bpf/usdt.bpf.h b/tools/lib/bpf/usdt.bpf.h
> index 0bd4c135a..f6763300b 100644
> --- a/tools/lib/bpf/usdt.bpf.h
> +++ b/tools/lib/bpf/usdt.bpf.h
> @@ -4,8 +4,8 @@
> #define __USDT_BPF_H__
>
> #include <linux/errno.h>
> -#include <bpf/bpf_helpers.h>
> -#include <bpf/bpf_tracing.h>
> +#include "bpf_helpers.h"
> +#include "bpf_tracing.h"
>
> /* Below types and maps are internal implementation details of libbpf's USDT
> * support and are subjects to change. Also, bpf_usdt_xxx() API helpers should
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-08-02 14:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 8:05 [PATCH v2 bpf-next] libbpf: Use local includes inside the library Sergey Kacheev
2023-08-02 14:44 ` Yonghong Song [this message]
2023-08-02 15:55 ` Sergey Kacheev
2023-08-02 17:02 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e44382b-13a0-5346-c914-be0ae0c7edcd@linux.dev \
--to=yonghong.song@linux.dev \
--cc=bpf@vger.kernel.org \
--cc=s.kacheev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox