From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADB9B6FA1 for ; Wed, 2 Aug 2023 14:44:24 +0000 (UTC) Received: from out-90.mta1.migadu.com (out-90.mta1.migadu.com [IPv6:2001:41d0:203:375::5a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36F291FCF for ; Wed, 2 Aug 2023 07:44:22 -0700 (PDT) Message-ID: <2e44382b-13a0-5346-c914-be0ae0c7edcd@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1690987460; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ga9knVHXmMM+K8eZRec2dovV7ScH5HVBle/oJ9jB43E=; b=XQvzGhvOGgUg0yLFiBV4CPf3VbaEKZ+8NaFLW1p1GGDk8eLvucWq4L7XclV9drqGGlbVMM olyGgx/NrDsR1r/tzDQ2PTpQXrTlwo/0FmvnkN5dHcAQdJbkLX0Drt5ych8iMVedJ3516I sdakC67RydK7pKBLL7YZecKXBEFrVQc= Date: Wed, 2 Aug 2023 07:44:17 -0700 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-To: yonghong.song@linux.dev Subject: Re: [PATCH v2 bpf-next] libbpf: Use local includes inside the library Content-Language: en-US To: Sergey Kacheev , bpf@vger.kernel.org References: X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yonghong Song In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 8/2/23 1:05 AM, Sergey Kacheev wrote: > This patch makes it possible to import the header files of the bpf > part directly from the source tree. Could you describe more about your workflow why this patch is necessary? I would like to understand whether this is a bug fix for your workflow or something else. > > Signed-off-by: Sergey Kacheev > --- > Changes from v1: > - Replaced the patch for github/libpf with a patch for bpf-next Linux > source tree > Reference: > - v1: https://lore.kernel.org/bpf/CAJVhQqXomJeO_23DqNWO9KUU-+pwVFoae0Xj=8uH2V=N0mOUSg@mail.gmail.com/ > --- > tools/lib/bpf/bpf_tracing.h | 2 +- > tools/lib/bpf/usdt.bpf.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/lib/bpf/bpf_tracing.h b/tools/lib/bpf/bpf_tracing.h > index be076a404..3803479db 100644 > --- a/tools/lib/bpf/bpf_tracing.h > +++ b/tools/lib/bpf/bpf_tracing.h > @@ -2,7 +2,7 @@ > #ifndef __BPF_TRACING_H__ > #define __BPF_TRACING_H__ > > -#include > +#include "bpf_helpers.h" > > /* Scan the ARCH passed in from ARCH env variable (see Makefile) */ > #if defined(__TARGET_ARCH_x86) > diff --git a/tools/lib/bpf/usdt.bpf.h b/tools/lib/bpf/usdt.bpf.h > index 0bd4c135a..f6763300b 100644 > --- a/tools/lib/bpf/usdt.bpf.h > +++ b/tools/lib/bpf/usdt.bpf.h > @@ -4,8 +4,8 @@ > #define __USDT_BPF_H__ > > #include > -#include > -#include > +#include "bpf_helpers.h" > +#include "bpf_tracing.h" > > /* Below types and maps are internal implementation details of libbpf's USDT > * support and are subjects to change. Also, bpf_usdt_xxx() API helpers should > -- > 2.39.2 >