From: Vineet Gupta <vineet.gupta@linux.dev>
To: Alan Maguire <alan.maguire@oracle.com>, dwarves@vger.kernel.org
Cc: bpf@vger.kernel.org, Andrii Nakryiko <andrii@kernel.org>,
acme@kernel.org, jose.marchesi@oracle.com,
David Faust <david.faust@oracle.com>
Subject: Re: [PAHOLE Patch v2 1/2] dwarf_loader: Extract die__add_btf_type_tag() helper [NFC]
Date: Fri, 29 May 2026 11:11:43 -0700 [thread overview]
Message-ID: <2fb9e4df-d906-46e7-8239-79025b628e5b@linux.dev> (raw)
In-Reply-To: <8c8826d1-6534-4aef-8129-5c8da61f731e@oracle.com>
Hi Alan,
On 5/29/26 06:23, Alan Maguire wrote:
> looks good Vineet! One small suggestion:
>
>> +static int die__add_btf_type_tag(struct btf_type_tag_ptr_type **tagp,
>> + Dwarf_Die *die, Dwarf_Die *adie,
>> + struct cu *cu, struct conf_load *conf)
> maybe just change the function to return the struct btf_type_tag_ptr_type *,
> since consumers just check for non-zero rather than doing anything with the
> error code?
OK will do.
Thx for taking a look.
-Vineet
prev parent reply other threads:[~2026-05-29 18:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 22:36 [PAHOLE Patch v2 1/2] dwarf_loader: Extract die__add_btf_type_tag() helper [NFC] Vineet Gupta
2026-05-28 22:36 ` [PAHOLE Patch v2 2/2] Add support for DW_TAG_GNU_annotation Vineet Gupta
2026-05-29 13:37 ` Alan Maguire
2026-05-29 23:32 ` Vineet Gupta
2026-05-30 1:31 ` Vineet Gupta
2026-05-29 13:23 ` [PAHOLE Patch v2 1/2] dwarf_loader: Extract die__add_btf_type_tag() helper [NFC] Alan Maguire
2026-05-29 18:11 ` Vineet Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fb9e4df-d906-46e7-8239-79025b628e5b@linux.dev \
--to=vineet.gupta@linux.dev \
--cc=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=david.faust@oracle.com \
--cc=dwarves@vger.kernel.org \
--cc=jose.marchesi@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox