Re: [PATCH bpf-next 7/7] selftests/bpf: Enable cpu v4 tests for arm64

Yonghong Song
2023-08-18T15:34:37Z

On 8/18/23 7:04 AM, Daniel Borkmann wrote:
> On 8/16/23 4:31 AM, Xu Kuohai wrote:
>> On 8/16/2023 9:57 AM, Yonghong Song wrote:
>>> On 8/15/23 6:28 PM, Xu Kuohai wrote:
>>>> On 8/16/2023 12:57 AM, Yonghong Song wrote:
>>>>> On 8/15/23 8:41 AM, Xu Kuohai wrote:
>>>>>> From: Xu Kuohai <xukuohai@huawei.com>
>>>>>>
>>>>>> Enable cpu v4 instruction tests for arm64.
>>>>>>
>>>>>> Signed-off-by: Xu Kuohai <xukuohai@huawei.com>
>>>>>
>>>>> Thanks for adding cpu v4 support for arm64. The CI looks green as
>>>>> well for arm64.
>>>>>
>>>>> https://github.com/kernel-patches/bpf/actions/runs/5868919914/job/15912774884?pr=5525
>>>>
>>>> Well, it looks like the CI's clang doesn't support cpu v4 yet:
>>>>
>>>>    #306/1   verifier_bswap/cpuv4 is not supported by compiler or
>>>> jit, use a dummy test:OK
>>>>    #306     verifier_bswap:OK
>>>>
>>>>> Ack this patch which enabled cpu v4 tests for arm64.
>>>
>>> Ah. Sorry. Could you paste your local cpu v4 run results for
>>> these related tests in the commit message then?
>>
>> Sure. The results are as follows. I'll post these in the commit message.
>
> Thanks, I've added these to the commit message given Florent's review and
> tests came in.
>
> Yonghong, did you ping all other JIT folks as well, so they are aware
> and have
> a chance to look into adding support for their archs?

Thanks, Daniel for reminder. Will ping them soon to get
cpu v4 support for other arch's as well.

>
> Thanks,
> Daniel
>