Re: [PATCH bpf-next 7/7] selftests/bpf: Enable cpu v4 tests for arm64

Yonghong Song
2023-08-16T01:57:57Z

On 8/15/23 6:28 PM, Xu Kuohai wrote:
> On 8/16/2023 12:57 AM, Yonghong Song wrote:
>>
>>
>> On 8/15/23 8:41 AM, Xu Kuohai wrote:
>>> From: Xu Kuohai <xukuohai@huawei.com>
>>>
>>> Enable cpu v4 instruction tests for arm64.
>>>
>>> Signed-off-by: Xu Kuohai <xukuohai@huawei.com>
>>
>> Thanks for adding cpu v4 support for arm64. The CI looks green as well
>> for arm64.
>>
>> https://github.com/kernel-patches/bpf/actions/runs/5868919914/job/15912774884?pr=5525
>>
>
> Well, it looks like the CI's clang doesn't support cpu v4 yet:
>
>   #306/1   verifier_bswap/cpuv4 is not supported by compiler or jit,
> use a dummy test:OK
>   #306     verifier_bswap:OK
>
>> Ack this patch which enabled cpu v4 tests for arm64.

Ah. Sorry. Could you paste your local cpu v4 run results for
these related tests in the commit message then?

>>
>> Acked-by: Yonghong Song <yonghong.song@linux.dev>
>>
>>> ---
>>>   tools/testing/selftests/bpf/progs/test_ldsx_insn.c | 2 +-
>>>   tools/testing/selftests/bpf/progs/verifier_bswap.c | 2 +-
>>>   tools/testing/selftests/bpf/progs/verifier_gotol.c | 2 +-
>>>   tools/testing/selftests/bpf/progs/verifier_ldsx.c  | 2 +-
>>>   tools/testing/selftests/bpf/progs/verifier_movsx.c | 2 +-
>>>   tools/testing/selftests/bpf/progs/verifier_sdiv.c  | 2 +-
>>>   6 files changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/tools/testing/selftests/bpf/progs/test_ldsx_insn.c
>>> b/tools/testing/selftests/bpf/progs/test_ldsx_insn.c
>>> index 321abf862801..916d9435f12c 100644
>>> --- a/tools/testing/selftests/bpf/progs/test_ldsx_insn.c
>>> +++ b/tools/testing/selftests/bpf/progs/test_ldsx_insn.c
>>> @@ -5,7 +5,7 @@
>>>   #include <bpf/bpf_helpers.h>
>>>   #include <bpf/bpf_tracing.h>
>>> -#if defined(__TARGET_ARCH_x86) && __clang_major__ >= 18
>>> +#if (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86)) &&
>>> __clang_major__ >= 18
>>>   const volatile int skip = 0;
>>>   #else
>>>   const volatile int skip = 1;
>> [...]
>>
>> .
>